Skip to content

Commit

Permalink
ci: also remove core from apex-node lib
Browse files Browse the repository at this point in the history
  • Loading branch information
mshanemc committed Nov 10, 2023
1 parent 3e9c988 commit d5b345f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
os: ${{ matrix.os }}
useCache: false
preSwapCommands: 'yarn upgrade jsforce@beta; npx yarn-deduplicate; yarn install'
preExternalBuildCommands: 'shx rm -rf node_modules/@salesforce/core/node_modules/jsforce shx rm -rf node_modules/@salesforce/sf-plugins-core/node_modules/@salesforce/core node_modules/@salesforce/cli-plugins-testkit/node_modules/@salesforce/core node_modules/@salesforce/source-tracking/node_modules/@salesforce/core node_modules/@salesforce/source-deploy-retrieve/node_modules/@salesforce/core'
preExternalBuildCommands: 'shx rm -rf node_modules/@salesforce/core/node_modules/jsforce shx rm -rf node_modules/@salesforce/sf-plugins-core/node_modules/@salesforce/core node_modules/@salesforce/cli-plugins-testkit/node_modules/@salesforce/core node_modules/@salesforce/source-tracking/node_modules/@salesforce/core node_modules/@salesforce/source-deploy-retrieve/node_modules/@salesforce/core node_modules/@salesforce/apex-node/node_modules/@salesforce/core'
secrets: inherit
# hidden until we fix source-testkit to better handle jwt
pdrNuts:
Expand Down

4 comments on commit d5b345f

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: d5b345f Previous: 3e9c988 Ratio
Child logger creation 295862 ops/sec (±2.84%) 493902 ops/sec (±0.56%) 1.67
Logging a string on root logger 498229 ops/sec (±8.91%) 811765 ops/sec (±10.19%) 1.63
Logging an object on root logger 341194 ops/sec (±8.77%) 616113 ops/sec (±9.04%) 1.81
Logging an object with a message on root logger 276297 ops/sec (±13.41%) 2595 ops/sec (±254.87%) 0.009392067232000348
Logging an object with a redacted prop on root logger 271319 ops/sec (±13.22%) 432070 ops/sec (±12.86%) 1.59
Logging a nested 3-level object on root logger 1488 ops/sec (±234.43%) 373136 ops/sec (±8.17%) 250.76

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - ubuntu-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: d5b345f Previous: 3e9c988 Ratio
Logging a nested 3-level object on root logger 1488 ops/sec (±234.43%) 373136 ops/sec (±8.17%) 250.76

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: d5b345f Previous: 3e9c988 Ratio
Child logger creation 319236 ops/sec (±0.76%) 206821 ops/sec (±5.84%) 0.65
Logging a string on root logger 812081 ops/sec (±5.57%) 494880 ops/sec (±8.41%) 0.61
Logging an object on root logger 602785 ops/sec (±4.91%) 317757 ops/sec (±12.16%) 0.53
Logging an object with a message on root logger 5769 ops/sec (±207.36%) 166290 ops/sec (±21.65%) 28.82
Logging an object with a redacted prop on root logger 455806 ops/sec (±12.88%) 187603 ops/sec (±22.55%) 0.41
Logging a nested 3-level object on root logger 334782 ops/sec (±5.46%) 98829 ops/sec (±23.90%) 0.30

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - windows-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: d5b345f Previous: 3e9c988 Ratio
Logging an object with a message on root logger 5769 ops/sec (±207.36%) 166290 ops/sec (±21.65%) 28.82

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.