Skip to content

Commit

Permalink
ci: remove test folder to avoid a plugin running sfdx-core's NUTs
Browse files Browse the repository at this point in the history
  • Loading branch information
@mshanemc
mshanemc committed Aug 7, 2024
1 parent d1f78e7 commit db74243
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/test.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ jobs:
command: 'yarn test:nuts'
os: ${{ matrix.os }}
useCache: false
# remove the test folder for sfdx-core
preBuildCommands: 'rm -rf test'
preSwapCommands: 'yarn upgrade @jsforce/jsforce-node@latest; npx yarn-deduplicate; yarn install'
preExternalBuildCommands: 'shx rm -rf node_modules/@salesforce/core/node_modules/@jsforce/jsforce-node shx rm -rf node_modules/@salesforce/sf-plugins-core/node_modules/@salesforce/core node_modules/@salesforce/cli-plugins-testkit/node_modules/@salesforce/core node_modules/@salesforce/source-tracking/node_modules/@salesforce/core node_modules/@salesforce/source-deploy-retrieve/node_modules/@salesforce/core node_modules/@salesforce/apex-node/node_modules/@salesforce/core'
secrets: inherit
Expand Down

3 comments on commit db74243

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: db74243 Previous: d1f78e7 Ratio
Child logger creation 476400 ops/sec (±1.17%) 454516 ops/sec (±2.15%) 0.95
Logging a string on root logger 773818 ops/sec (±7.81%) 814171 ops/sec (±11.89%) 1.05
Logging an object on root logger 610761 ops/sec (±7.56%) 637814 ops/sec (±6.66%) 1.04
Logging an object with a message on root logger 5910 ops/sec (±210.28%) 22445 ops/sec (±184.89%) 3.80
Logging an object with a redacted prop on root logger 451650 ops/sec (±5.09%) 448487 ops/sec (±6.71%) 0.99
Logging a nested 3-level object on root logger 387075 ops/sec (±8.02%) 27164 ops/sec (±182.67%) 0.07017761415746303

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - ubuntu-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: db74243 Previous: d1f78e7 Ratio
Logging an object with a message on root logger 5910 ops/sec (±210.28%) 22445 ops/sec (±184.89%) 3.80

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: db74243 Previous: d1f78e7 Ratio
Child logger creation 344239 ops/sec (±0.22%) 333307 ops/sec (±0.67%) 0.97
Logging a string on root logger 840198 ops/sec (±7.86%) 831634 ops/sec (±5.93%) 0.99
Logging an object on root logger 582585 ops/sec (±4.25%) 618664 ops/sec (±6.85%) 1.06
Logging an object with a message on root logger 3911 ops/sec (±215.26%) 3136 ops/sec (±220.89%) 0.80
Logging an object with a redacted prop on root logger 418437 ops/sec (±16.18%) 481948 ops/sec (±7.50%) 1.15
Logging a nested 3-level object on root logger 310570 ops/sec (±5.21%) 328924 ops/sec (±8.24%) 1.06

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.