Skip to content

Commit

Permalink
fix: set stack to fullStack if set
Browse files Browse the repository at this point in the history
  • Loading branch information
@shetzel
shetzel committed Nov 16, 2023
1 parent a632beb commit dd051bd
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/sfError.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ export class SfError extends NamedError {
} else {
this.exitCode = 1;
}
if (this.fullStack) {
this.stack = this.fullStack;
}
}

// eslint-disable-next-line @typescript-eslint/no-explicit-any
Expand Down

3 comments on commit dd051bd

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: dd051bd Previous: e9a2a5f Ratio
Child logger creation 468273 ops/sec (±2.31%) 460743 ops/sec (±2.66%) 0.98
Logging a string on root logger 738802 ops/sec (±8.52%) 715152 ops/sec (±9.31%) 0.97
Logging an object on root logger 596845 ops/sec (±8.39%) 598983 ops/sec (±6.73%) 1.00
Logging an object with a message on root logger 14232 ops/sec (±189.39%) 12859 ops/sec (±199.56%) 0.90
Logging an object with a redacted prop on root logger 486264 ops/sec (±4.50%) 446004 ops/sec (±8.79%) 0.92
Logging a nested 3-level object on root logger 376838 ops/sec (±9.25%) 367085 ops/sec (±6.56%) 0.97

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: dd051bd Previous: e9a2a5f Ratio
Child logger creation 319902 ops/sec (±0.92%) 337264 ops/sec (±3.24%) 1.05
Logging a string on root logger 846988 ops/sec (±7.91%) 766388 ops/sec (±7.71%) 0.90
Logging an object on root logger 657782 ops/sec (±7.73%) 533389 ops/sec (±7.26%) 0.81
Logging an object with a message on root logger 12701 ops/sec (±188.88%) 270126 ops/sec (±8.56%) 21.27
Logging an object with a redacted prop on root logger 479070 ops/sec (±8.50%) 6029 ops/sec (±211.36%) 0.012584799716116642
Logging a nested 3-level object on root logger 332719 ops/sec (±5.31%) 288705 ops/sec (±6.42%) 0.87

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - windows-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: dd051bd Previous: e9a2a5f Ratio
Logging an object with a message on root logger 12701 ops/sec (±188.88%) 270126 ops/sec (±8.56%) 21.27

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.