Skip to content

Commit

Permalink
style: fix comment
Browse files Browse the repository at this point in the history
  • Loading branch information
@mshanemc
mshanemc committed Nov 10, 2023
1 parent 4e66905 commit e4ba4f3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/messageTransformer.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export const messageTransformer = (): ts.TransformerFactory<ts.SourceFile> => {
const visitor = (node: ts.Node): ts.VisitResult<ts.Node> => {
if (ts.isExpressionStatement(node) && node.getText().includes('importMessagesDirectory')) {
// importMessagesDirectory now happens at compile, not in runtime
// returning undefined removes the node
// so we can remove it
return ts.factory.createEmptyStatement();
}
if (
Expand Down

4 comments on commit e4ba4f3

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: e4ba4f3 Previous: 2b6556b Ratio
Child logger creation 345645 ops/sec (±0.53%) 485988 ops/sec (±1.35%) 1.41
Logging a string on root logger 708564 ops/sec (±11.42%) 752798 ops/sec (±7.66%) 1.06
Logging an object on root logger 488628 ops/sec (±9.61%) 563844 ops/sec (±7.51%) 1.15
Logging an object with a message on root logger 288350 ops/sec (±11.36%) 11117 ops/sec (±199.49%) 0.0385538408184498
Logging an object with a redacted prop on root logger 21720 ops/sec (±184.59%) 394247 ops/sec (±13.08%) 18.15
Logging a nested 3-level object on root logger 275807 ops/sec (±9.69%) 351134 ops/sec (±9.68%) 1.27

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - ubuntu-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: e4ba4f3 Previous: 2b6556b Ratio
Logging an object with a redacted prop on root logger 21720 ops/sec (±184.59%) 394247 ops/sec (±13.08%) 18.15

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: e4ba4f3 Previous: 2b6556b Ratio
Child logger creation 315906 ops/sec (±3.79%) 198750 ops/sec (±7.20%) 0.63
Logging a string on root logger 753302 ops/sec (±4.47%) 448751 ops/sec (±8.49%) 0.60
Logging an object on root logger 555188 ops/sec (±8.58%) 318766 ops/sec (±18.53%) 0.57
Logging an object with a message on root logger 10263 ops/sec (±198.66%) 225606 ops/sec (±16.53%) 21.98
Logging an object with a redacted prop on root logger 462972 ops/sec (±7.31%) 250078 ops/sec (±21.41%) 0.54
Logging a nested 3-level object on root logger 323879 ops/sec (±5.12%) 5621 ops/sec (±190.02%) 0.017355246866885474

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - windows-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: e4ba4f3 Previous: 2b6556b Ratio
Logging an object with a message on root logger 10263 ops/sec (±198.66%) 225606 ops/sec (±16.53%) 21.98

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.