Skip to content

Commit

Permalink
test: fix UT
Browse files Browse the repository at this point in the history
  • Loading branch information
@cristiand391
cristiand391 committed Jul 15, 2024
1 parent 60933a0 commit eff3301
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/unit/org/connectionTest.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const TEST_IP = '1.1.1.1';

describe('Connection', () => {
const $$ = new TestContext();
const testConnectionOptions = { loginUrl: 'connectionTest/loginUrl' };
const testConnectionOptions = { loginUrl: 'https://connectionTest/loginUrl' };
let requestMock: sinon.SinonStub;
let myDomainResolverStub: sinon.SinonStub;

Expand Down

3 comments on commit eff3301

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: eff3301 Previous: 7c6f9d7 Ratio
Child logger creation 480613 ops/sec (±0.53%) 484618 ops/sec (±0.91%) 1.01
Logging a string on root logger 838378 ops/sec (±6.98%) 847992 ops/sec (±9.46%) 1.01
Logging an object on root logger 593412 ops/sec (±7.67%) 43621 ops/sec (±183.83%) 0.07350879321618033
Logging an object with a message on root logger 6372 ops/sec (±210.14%) 446221 ops/sec (±6.11%) 70.03
Logging an object with a redacted prop on root logger 479359 ops/sec (±7.97%) 530472 ops/sec (±8.10%) 1.11
Logging a nested 3-level object on root logger 383025 ops/sec (±7.11%) 14677 ops/sec (±188.60%) 0.0383186476078585

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - ubuntu-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: eff3301 Previous: 7c6f9d7 Ratio
Logging an object with a message on root logger 6372 ops/sec (±210.14%) 446221 ops/sec (±6.11%) 70.03

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: eff3301 Previous: 7c6f9d7 Ratio
Child logger creation 325013 ops/sec (±0.73%) 334721 ops/sec (±0.70%) 1.03
Logging a string on root logger 804881 ops/sec (±5.28%) 756423 ops/sec (±6.44%) 0.94
Logging an object on root logger 627586 ops/sec (±7.22%) 602954 ops/sec (±5.55%) 0.96
Logging an object with a message on root logger 3074 ops/sec (±220.68%) 3491 ops/sec (±217.90%) 1.14
Logging an object with a redacted prop on root logger 422335 ops/sec (±10.27%) 470799 ops/sec (±7.86%) 1.11
Logging a nested 3-level object on root logger 328172 ops/sec (±5.69%) 335592 ops/sec (±5.52%) 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.