Mz/make bundleable #1026
Merged
Mz/make bundleable #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternhale
approved these changes
Feb 13, 2024
| @@ -4,6 +4,7 @@ | |||
| "compilerOptions": { | |||
| "noEmit": true, | |||
| "skipLibCheck": true, | |||
| "resolveJsonModule": true | |||
| "resolveJsonModule": true, | |||
| "esModuleInterop": true | |||
There was a problem hiding this comment.
'esModuleInterop' makes typescript compiler treat commonjs similar to ES6 modules.
I made the changes in all tsconfig.json. This way we abandon usage like import * as Faye from 'faye'; which esbuild does not support for commonjs module. Even if there is no change of code here in examples/test, it is still good to use it.
| @@ -11,7 +11,7 @@ import Transport from 'jsforce/lib/transport'; | |||
| import { AsyncCreatable, Duration, parseJsonMap, sleep } from '@salesforce/kit'; | |||
| import { HttpRequest, OAuth2Config } from 'jsforce'; | |||
| import { ensureString, isString, JsonMap, Nullable } from '@salesforce/ts-types'; | |||
| import * as FormData from 'form-data'; | |||
| import FormData from 'form-data'; | |||
There was a problem hiding this comment.
All changes like this are to make the import statement compatible with esbuild without hurting the existing compiling process of typescript compiler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
make the code bundle-able without affecting the existing workflow.
What issues does this PR fix or reference?
@W-15022712@
https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00001jzB1UYAU/view