Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: override whatwg-url #1109

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix: override whatwg-url #1109

merged 1 commit into from
Jul 29, 2024

Conversation

cristiand391
Copy link
Member

What does this PR do?

follow up of jsforce/jsforce#1542

we'll use yarn's resolutions here to override whatwg-url for our repos using yarn.

➜  sfdx-core git:(cd/override-whatwg-url) ls node_modules
ls: node_modules: No such file or directory
➜  sfdx-core git:(cd/override-whatwg-url) yarn install --production
yarn install v1.22.19
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
[4/5] 🔗  Linking dependencies...
warning " > [email protected]" has unmet peer dependency "@types/node@*".
warning "@salesforce/dev-scripts > [email protected]" has incorrect peer dependency "[email protected] || 4.7.x || 4.8.x || 4.9.x || 5.0.x || 5.1.x || 5.2.x || 5.3.x || 5.4.
x".
warning "@salesforce/dev-scripts > [email protected]" has incorrect peer dependency "[email protected] || 0.23.x".
warning Workspaces can only be enabled in private projects.
[5/5] 🔨  Building fresh packages...

✨  Done in 1.26s.
➜  sfdx-core git:(cd/override-whatwg-url) npm why whatwg-url
[email protected]
node_modules/whatwg-url

What issues does this PR fix or reference?

@W-14355613@

@WillieRuemmele WillieRuemmele merged commit 6ae0aee into main Jul 29, 2024
76 checks passed
@WillieRuemmele WillieRuemmele deleted the cd/override-whatwg-url branch July 29, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants