fix: dns lookup doesn't include port #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
changed the title
shetzel
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
this works fine in "normal" user land with normal instanceUrls
for weird internal, the DNS lookup fails because of the port being in the url
https://nodejs.org/api/url.html#urlhostname
hostname has no port (and dns.lookup is fine)
host has the port (and dns.lookup fails)
also, workspaces url have changed (was previously
wc.dev.crmbut lately seing morewb.dev.crm🤷🏻What issues does this PR fix or reference?
@W-17167313@
and also the issue where internals have to add
SF_DISABLE_DNS_CHECK:trueto avoid the port issue.