fix: handle multiple sandbox processes in resumable state #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shetzel
commented
Oct 2, 2023
| if (resumeSandboxRequest.SandboxName) { | ||
| sandboxCreationProgress = await this.querySandboxProcessBySandboxName(resumeSandboxRequest.SandboxName); | ||
| } else if (resumeSandboxRequest.SandboxProcessObjId) { | ||
| if (resumeSandboxRequest.SandboxProcessObjId) { |
There was a problem hiding this comment.
Prefer the SandboxProcessId over name since it's unique.
| expect(queryStub.firstCall.firstArg).to.be.equal(queryStr); | ||
| expect(pollStatusAndAuthStub.calledOnce).to.be.true; | ||
| expect(result).to.be.equal(statusResult.records[0]); | ||
| describe('createSandbox', () => { |
There was a problem hiding this comment.
Most of the changes here are reorganization of the existing tests to make more sense. I added a bunch of new tests as well in the resumeSandbox and querySandboxProcess sections.
| err.data = result; | ||
| throw err; | ||
| } | ||
| return result[0]; |
There was a problem hiding this comment.
This is mostly what Jochen's PR is, with some additions to the query to ORDER BY and augment the MultipleRecords error (data property) with the sandbox processes.
cristiand391
previously approved these changes
Oct 3, 2023
cristiand391
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
handle multiple sandbox processes in resumable state. The error that happens has the SandboxProcesses added to err.data , and a resume lifecycle event is fired with that data for consumers to act on.
What issues does this PR fix or reference?
@W-13635704@