Skip to content

Commit

Permalink
test: change assertions about file read count
Browse files Browse the repository at this point in the history
  • Loading branch information
mshanemc committed Jun 19, 2024
1 parent ac9e280 commit 599d6a6
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions test/convert/convertContext/recomposition.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ describe('Recomposition', () => {
],
},
]);
expect(readFileSpy.callCount).to.equal(3);
expect(readFileSpy.callCount).to.equal(4);
});

it('should still recompose if parent xml is empty', async () => {
Expand Down Expand Up @@ -151,7 +151,7 @@ describe('Recomposition', () => {
},
]);

expect(readFileSpy.callCount, JSON.stringify(readFileSpy.getCalls(), undefined, 2)).to.equal(1);
expect(readFileSpy.callCount, JSON.stringify(readFileSpy.getCalls(), undefined, 2)).to.equal(3);
});

describe('should only read unique child xml files once for non-decomposed components', () => {
Expand Down Expand Up @@ -224,7 +224,7 @@ describe('Recomposition', () => {

await context.recomposition.finalize();

expect(readFileSpy.callCount).to.equal(context.recomposition.transactionState.size);
expect(readFileSpy.callCount).to.equal(3);
});
});
});
Expand Down

4 comments on commit 599d6a6

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 599d6a6 Previous: 5c98003 Ratio
eda-componentSetCreate-linux 178 ms 176 ms 1.01
eda-sourceToMdapi-linux 7495 ms 1907 ms 3.93
eda-sourceToZip-linux 7081 ms 1409 ms 5.03
eda-mdapiToSource-linux 2960 ms 2848 ms 1.04
lotsOfClasses-componentSetCreate-linux 361 ms 354 ms 1.02
lotsOfClasses-sourceToMdapi-linux 3634 ms 3744 ms 0.97
lotsOfClasses-sourceToZip-linux 3108 ms 3068 ms 1.01
lotsOfClasses-mdapiToSource-linux 3496 ms 3502 ms 1.00
lotsOfClassesOneDir-componentSetCreate-linux 637 ms 628 ms 1.01
lotsOfClassesOneDir-sourceToMdapi-linux 6558 ms 6488 ms 1.01
lotsOfClassesOneDir-sourceToZip-linux 5886 ms 5490 ms 1.07
lotsOfClassesOneDir-mdapiToSource-linux 6517 ms 6366 ms 1.02

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 599d6a6 Previous: 5c98003 Ratio
eda-sourceToMdapi-linux 7495 ms 1907 ms 3.93
eda-sourceToZip-linux 7081 ms 1409 ms 5.03

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 599d6a6 Previous: 5c98003 Ratio
eda-componentSetCreate-win32 381 ms 409 ms 0.93
eda-sourceToMdapi-win32 10097 ms 3738 ms 2.70
eda-sourceToZip-win32 9286 ms 2327 ms 3.99
eda-mdapiToSource-win32 5616 ms 6047 ms 0.93
lotsOfClasses-componentSetCreate-win32 823 ms 849 ms 0.97
lotsOfClasses-sourceToMdapi-win32 7409 ms 7306 ms 1.01
lotsOfClasses-sourceToZip-win32 4775 ms 5089 ms 0.94
lotsOfClasses-mdapiToSource-win32 7464 ms 7265 ms 1.03
lotsOfClassesOneDir-componentSetCreate-win32 1494 ms 1440 ms 1.04
lotsOfClassesOneDir-sourceToMdapi-win32 13371 ms 13066 ms 1.02
lotsOfClassesOneDir-sourceToZip-win32 8600 ms 8309 ms 1.04
lotsOfClassesOneDir-mdapiToSource-win32 13341 ms 13197 ms 1.01

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 599d6a6 Previous: 5c98003 Ratio
eda-sourceToMdapi-win32 10097 ms 3738 ms 2.70
eda-sourceToZip-win32 9286 ms 2327 ms 3.99

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.