chore: lint fixes

src/collections/componentSet.ts

@@ -443,11 +443,7 @@ export class ComponentSet extends LazyCollection<MetadataComponent> {
       addToTypeMap({
         typeMap,
         type: type.folderContentType ? this.registry.getTypeByName(type.folderContentType) : type,
-        fullName:
-          this.registry.getParentType(type.name)?.strategies?.recomposition === 'startEmpty' && fullName.includes('.')
-            ? // they're reassembled like CustomLabels.MyLabel
-              fullName.split('.')[1]
-            : fullName,
+        fullName: constructFullName(this.registry, type, fullName),
         destructiveType,
       });
     });
@@ -738,6 +734,16 @@ const splitOnFirstDelimiter = (input: string): [string, string] => {
   return [input.substring(0, indexOfSplitChar), input.substring(indexOfSplitChar + 1)];
 };
 
+const constructFullName = (registry: RegistryAccess, type: MetadataType, fullName: string): string =>
+  // InFolder types are different (e.g., Report/ReportFolder). ReportFolders are deployed/retrieved as Reports.
+  // If a ReportFolder is being added append a "/" so the metadata API can identify it as a folder.
+  type.folderContentType && !fullName.endsWith('/')
+    ? `${fullName}/`
+    : registry.getParentType(type.name)?.strategies?.recomposition === 'startEmpty' && fullName.includes('.')
+    ? // they're reassembled like CustomLabels.MyLabel
+      fullName.split('.')[1]
+    : fullName;
+
 /** side effect: mutates the typeMap property */
 const addToTypeMap = ({
   typeMap,

test/nuts/local/replacements/replacements.nut.ts

@@ -116,7 +116,7 @@ describe('e2e replacements test', () => {
       if (image && !image.dir) {
         const content = await image.async('nodebuffer');
         // The file size would be much larger if it was corrupted via the string replacement method
-        expect(content.byteLength).to.equal(1562121);
+        expect(content.byteLength).to.equal(1_562_121);
       }
     });
   });

test/snapshot/sampleProjects/nestedFolders/__snapshots__/verify-md-files.expected/package.xml

@@ -1,14 +1,14 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Package xmlns="http://soap.sforce.com/2006/04/metadata">
     <types>
-        <members>Top_Level_Folder</members>
+        <members>Top_Level_Folder/</members>
         <members>Top_Level_Folder/Template_in_folder</members>
         <members>unfiled$public/Top_level_email</members>
         <name>EmailTemplate</name>
     </types>
     <types>
-        <members>TopFolder</members>
-        <members>TopFolder/ChildFolder</members>
+        <members>TopFolder/</members>
+        <members>TopFolder/ChildFolder/</members>
         <members>TopFolder/ChildFolder/Report_in_Child_Folder_qz4</members>
         <members>TopFolder/Copy_of_Top_level_report_DOj</members>
         <members>unfiled$public/Top_level_report_cZJ</members>