-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build ComponentSet using metadata and an org connection #1182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No required changes, just style stuff. Would QA as is if you wanted
logger.debug(`Building ComponentSet from targetUsername: ${org.username}`); | ||
|
||
let debugMsg = `Building ComponentSet from targetUsername: ${org.username}`; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meta: I know we turned off the complexity
rule but that just lets this get worse with each change.
could there be a function at the bottom that returns [message: string, filter: [that matches your shape>]] ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and maybe extract the logging stuff (lines 215-230 as a fn)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could also the iteration at 122 as a fn (pass in a CS and the metadata object, get back a CS)
QA notes: throwing retrieves at my devHub. ✅ There are 5 object (well, one's a __e PlatformEvent) returned with Then I did a
✅ unsupported types produce a good error. |
What does this PR do?
Enhances
ComponentSetBuilder.build()
to use both metadata and an org connection when defined in the options. This allows metadata fullName retrieval from an org based on a pattern where the files are not in the local project.What issues does this PR fix or reference?
@W-14284096@
forcedotcom/cli#2522
QA suggestions:
Use dreamhouse-lwc repo deployed to a scratch org.
"ApexClass:Test*"
,"ApexClass:T*"
,"ApexClass:Test*,ApexClass:Geo*"
,"ApexClass:Test*,CustomObject:Prop*"
"ApexClass:Test*"
,"ApexClass:T*"
,"ApexClass:Test*,ApexClass:Geo*"
,"ApexClass:Test*,CustomObject:Prop*"
"ApexClass:Test*"
,"ApexClass:T*"
,"ApexClass:Test*,ApexClass:Geo*"
,"ApexClass:Test*,CustomObject:Prop*"
Test*
apex classes locally and keep the other one, then retrieve"ApexClass:Test*"
. It should retrieve all of them.