-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: snapshot tests #1218
Merged
Merged
test: snapshot tests #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds
mocha-snap
for testingsnapshots (jest-style) the round trip conversion between mdapi and source format for various types in sample projects.
The goal is to make this simpler for contributors (and us!) to define the behavior of these types using projects and files rather than hardcoded asserts about the projects/files
These tests could be enhanced with things like
These types were selected because they're not the "basic" ones and are ones that are likely candidates for registryCustomizations change. If I do registry presets for any other types not covered by this PR, I'll probably create snapshots for their existing behavior to make sure they work correctly.
What issues does this PR fix or reference?
@W-14608972@