Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: snapshot tests #1218

Merged
merged 38 commits into from
Feb 14, 2024
Merged

test: snapshot tests #1218

merged 38 commits into from
Feb 14, 2024

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Jan 19, 2024

What does this PR do?

adds mocha-snap for testing
snapshots (jest-style) the round trip conversion between mdapi and source format for various types in sample projects.

The goal is to make this simpler for contributors (and us!) to define the behavior of these types using projects and files rather than hardcoded asserts about the projects/files

These tests could be enhanced with things like

  • convert from MPD source project
  • apply a retrieved-like mdapi onto an MPD project (check file matching behavior)

These types were selected because they're not the "basic" ones and are ones that are likely candidates for registryCustomizations change. If I do registry presets for any other types not covered by this PR, I'll probably create snapshots for their existing behavior to make sure they work correctly.

What issues does this PR fix or reference?

@W-14608972@

@mshanemc mshanemc requested a review from a team as a code owner January 19, 2024 16:07
@mshanemc mshanemc marked this pull request as ready for review February 13, 2024 18:37
@shetzel shetzel merged commit 0df9811 into main Feb 14, 2024
64 of 68 checks passed
@shetzel shetzel deleted the sm/approval-tests branch February 14, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants