Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wr/decompose permission sets #1412

Merged
merged 31 commits into from
Sep 15, 2024
Merged

Wr/decompose permission sets #1412

merged 31 commits into from
Sep 15, 2024

Conversation

WillieRuemmele
Copy link
Member

@WillieRuemmele WillieRuemmele commented Sep 3, 2024 •
edited
Loading

@W-16627285@

adds decomposedPermissionSetBeta2 as a preset
see the .md for how it decomposes the file

@WillieRuemmele
chore: add initial dpsb2 preset / cloned from dpsb
457f8f5
@WillieRuemmele
chore: add new transformer/adapter, default for now
d6c5ca1
@WillieRuemmele
chore: update adapters/transformers with decomposed as base
8a29f76
@WillieRuemmele
chore: a lot of changes, writing xml in dirs, now to group by object
4b24bd8
@WillieRuemmele
fix: decomposing - very messy
f2e9353
@WillieRuemmele
fix: recomposing writing file, wrong child entry name CA, not cA
6cc84d4
@WillieRuemmele
fix: decomposing, recomposing
37874cd
@WillieRuemmele
chore: remove unused adapter
bc10579
@WillieRuemmele
refactor: first round of cleanup
36c5e1c
@WillieRuemmele
test: add snapshot
859e403
@WillieRuemmele
refactor: combine writeInfo methods
945fdde
@WillieRuemmele
test: filter decompPS2 preset, not valid as registry entry
7a95dcd
@WillieRuemmele
chore: bump core
61a7637
@WillieRuemmele
chore: merge main, resolve conflicts
d1077cb
@WillieRuemmele
test: export shared functions from Decomposed, add UT
5b55a72
@WillieRuemmele
chore: merge main, resolve conflicts
a91ff29
@WillieRuemmele
docs: update preset description
56c5085
shetzel
shetzel reviewed Sep 9, 2024
View reviewed changes
src/Presets.md Show resolved Hide resolved
src/Presets.md Outdated Show resolved Hide resolved
src/convert/convertContext/decomposedPermissionSetFinalizer.ts Outdated Show resolved Hide resolved
src/convert/convertContext/decomposedPermissionSetFinalizer.ts Show resolved Hide resolved
src/convert/convertContext/decomposedPermissionSetFinalizer.ts Outdated Show resolved Hide resolved
src/convert/transformers/decomposedPermissionSetTransformer.ts Show resolved Hide resolved
src/convert/transformers/decomposedPermissionSetTransformer.ts Outdated Show resolved Hide resolved
src/convert/transformers/decomposedPermissionSetTransformer.ts Outdated Show resolved Hide resolved
test/mock/type-constants/decomposedPermissionSetConstant.ts Show resolved Hide resolved
src/convert/transformers/decomposedMetadataTransformer.ts Outdated Show resolved Hide resolved
@WillieRuemmele WillieRuemmele force-pushed the wr/decomposePermissionSets branch from 233cae5 to 9055fd9 Compare September 10, 2024 20:40
@WillieRuemmele WillieRuemmele marked this pull request as ready for review September 10, 2024 22:13
@WillieRuemmele WillieRuemmele requested a review from a team as a code owner September 10, 2024 22:13
@shetzel
Copy link
Contributor

shetzel commented Sep 15, 2024

QA

  1. With changes, tested normal deploy, retrieve, and convert behavior of permission sets. All worked as expected.
  2. Switched to use the beta2 permission set source behavior. Tested deploy, retrieve and convert and all worked as expected.
  3. Tested source tracking of beta2 permission set source behavior and deploy, retrieve, preview worked as expected.
  4. Tested multiple package directory deploy, retrieve and convert and all worked as expected.

@shetzel shetzel merged commit 3650332 into main Sep 15, 2024
74 checks passed
@shetzel shetzel deleted the wr/decomposePermissionSets branch September 15, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shetzel shetzel shetzel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WillieRuemmele @shetzel @svc-cli-bot