Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch URI Malformed error #531

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix: catch URI Malformed error #531

merged 1 commit into from
Jan 18, 2024

Conversation

shetzel
Copy link
Collaborator

@shetzel shetzel commented Jan 18, 2024

What does this PR do?

Catches and logs attempts to decode a SourceMember key that is not decodable to prevent URIError: URI malformed during source tracking operations. Adds a unit test for it.

What issues does this PR fix or reference?

@W-14842075@

Copy link
Member

@cristiand391 cristiand391 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that try/catch should work to continue the execution.

question: in which scenarios can one get an invalid key here?

@shetzel
Copy link
Collaborator Author

shetzel commented Jan 18, 2024

question: in which scenarios can one get an invalid key here?

If you create a layout or profile in an org with a string that doesn't decode, then try to retrieve it with sf project retrieve start (using source tracking) this would happen. It might happen with sf project retrieve preview as well.

@shetzel shetzel merged commit 224393e into main Jan 18, 2024
32 checks passed
@shetzel shetzel deleted the sh/catch-URI-malformed branch January 18, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants