-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: memory usage on giant repos #591
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
commented
May 24, 2024
const getInfo = async (targetTree: Walker, filenameSet: Set<string>): Promise<FileInfo[]> => | ||
// Unable to properly type the return value of git.walk without using "as", ignoring linter | ||
// eslint-disable-next-line @typescript-eslint/no-unsafe-return | ||
git.walk({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unlike the StatusMatrix which supports a filter
, .walk
is going to run the map
async callback on every file. That seemed fine in our integration tests, but real-world projects are potentially going to have a LOT of
- git history (.git)
- tracking (.sf/.sfdx)
- potentially other
.
files
QA NOTES
|
iowillhoit
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
forcedotcom/cli#2880
@W-15840593@
test perf
on exact code from
main
✔ should show 0 files in git status after moving them (10703ms)
on code from main modified with 100_000 local non-project files,
✔ should show 0 files in git status after moving them (17424ms)
this PR with 100_000 local non-project files,
✔ should show 0 files in git status after moving them (12291ms)