Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: changes for customLabelsBeta v2 #651

Merged
merged 9 commits into from
Aug 15, 2024
Merged

fix: changes for customLabelsBeta v2 #651

merged 9 commits into from
Aug 15, 2024

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Aug 9, 2024

this does NOT require the SDR change to be merged first. It might be easier to merge this PR first (it'll have no effect) to help QA the SDR PR

What does this PR do?

  • there was some custom logic in STL for labels that isn't necessary with the beta preset.
  • use the registry STL already has in more places
  • use more top-level imports from sfdx-core

What issues does this PR fix or reference?

@W-16375268@

@mshanemc mshanemc requested a review from a team as a code owner August 9, 2024 14:16
@mshanemc mshanemc mentioned this pull request Aug 9, 2024
Merged
@shetzel shetzel merged commit 405e3b9 into main Aug 15, 2024
34 checks passed
@shetzel shetzel deleted the sm/custom-labels-beta-2 branch August 15, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shetzel shetzel shetzel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshanemc @shetzel @svc-cli-bot