Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run pre-push hooks when deleting remote branches #207

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joshka
Copy link
Contributor

@joshka joshka commented Aug 26, 2023

Fixes #204

@foriequal0
Copy link
Owner

Thank you for the PR!
I approve this PR and I could merge this PR at this time.
But I'm sorry to say that I might not be able to go through release process since I'm a little bit low on mental/time capacity for a while with personal issues, workload at work, etc.
(Although I can just bump and tag a new version and let CI handle the process, I'm not sure it'll still work after the last release. It might need some works due like following up dependencies updates, etc.)
I'll release a new version as I get better.
Thank you for your understanding.

@joshka
Copy link
Contributor Author

joshka commented Oct 18, 2023

No problem. This isn't a massive blocker for me (I was just following up on some old PRs) and life comes first of course so no rush.

I took a quick look at updating the dependencies and it seems that the git2 update breaks a few tests. I might dive in at some point and take a stab at fixing it.

@joshka
Copy link
Contributor Author

joshka commented Jun 1, 2024

Hey there @foriequal0 I hope you're doing well.

In #209 I updated all the dependencies.

* Bump vergen to 9.0

* Bump all deps
@foriequal0
Copy link
Owner

foriequal0 commented Dec 28, 2024

It took too long. I'll cleanup some tests and lints.
It'll resolve #209, #213, and some dependabot PRs at once.

@joshka
Copy link
Contributor Author

joshka commented Dec 28, 2024

It took too long. I'll cleanup some tests and lints. It'll resolve #209, #213, and some dependabot PRs at once.

Oh cool - I was just starting to look at forking this and dong a bunch of maintenance things / changes. Glad to see you're back on to things instead.

@foriequal0
Copy link
Owner

Please rebase onto the new master branch, then I'll merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting remote branches should not run the pre-push hook
3 participants