RIIR, add deeper tests, drop kustomization #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foriequal0
changed the title
foriequal0
changed the title
foriequal0
force-pushed
the
riir
branch
9 times, most recently
from
a5e7055 to
f33ed02
Compare
foriequal0
force-pushed
the
riir
branch
5 times, most recently
from
dfe8956 to
c4974c0
Compare
# Conflicts: # .github/workflows/ci.yaml # config/manager/manager.yaml
foriequal0
force-pushed
the
riir
branch
8 times, most recently
from
046ab93 to
024a053
Compare
Open
foriequal0
force-pushed
the
riir
branch
14 times, most recently
from
64ca342 to
9209011
Compare
It's not maintained anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't understand how controller-runtime written in Go worked even if they had a (slightly) better documentation, so I rewrote it in Rust.
It is about
+8,000 −4,500, butCargo.lockis+3,000, so it's basically+5,000 -4,500😉It has deeper tests that interact with Kubernetes API.
I tested and learned what methods work and what don't with these tests.
There's a (barely existing, but enough to prove) multi-version matrix smoke-tests.
I never understood the controller-runtime generated configuration,
and
kustomizeasking me to update it due to deprecation.So I dropped Kustomization.
I've removed uncertain flags.
Also, I've reduced the maximum delay timeout to 25 seconds due to the webhook timeout limit.
It should be okay for most of the time.