Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ESPFlashTool to support DHCP settings #666

Closed
wants to merge 2 commits into from

Conversation

MartinMueller2003
Copy link
Collaborator

Also added a dist.zip file that people can download if they cannot access the CI builds.

Copy link
Owner

@forkineye forkineye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove dist.zip? I know it's a convenience thing, but I can add an action if we want to start making CI builds available elsewhere. Also, can you try to git rm --cached on the pycache directories? It's in the .gitignore, but look like I accidently commited them 3 years ago with an esptool upgrade. That should keep them from updating in git.

forkineye added a commit that referenced this pull request Sep 19, 2023
Upgraded jSerialComm to 2.10.3
Removed __pycache__ directories that were missed by .gitignore
@forkineye
Copy link
Owner

Fixed in this commit - e37fd85

@forkineye forkineye closed this Sep 19, 2023
@MartinMueller2003
Copy link
Collaborator Author

Yes please I have multiple people that do not have access to the CI builds that ask for dist.zips as they are created. I have been putting them on googledrive but having them in the official repository would be better.

@forkineye
Copy link
Owner

Yes please I have multiple people that do not have access to the CI builds that ask for dist.zips as they are created. I have been putting them on googledrive but having them in the official repository would be better.

I'll add an action that pushes them to the pages branch and we can host them there above where doxy pushes the code docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants