Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full I2C OLED support with different screen sizes/types #741

Closed
wants to merge 0 commits into from
Closed

Full I2C OLED support with different screen sizes/types #741

wants to merge 0 commits into from

Conversation

noman1228
Copy link

I hope this is getting closer to what you guys are expecting. I'm also close to having a full BOM list and PCB design to add.
ESP-JMT

@MartinMueller2003 MartinMueller2003 self-assigned this Feb 27, 2024
MartinMueller2003
MartinMueller2003 reviewed Feb 27, 2024
View reviewed changes
ESPixelStick/ESPixelStick.ino Outdated Show resolved Hide resolved
ESPixelStick/ESPixelStick.ino Outdated Show resolved Hide resolved
ESPixelStick/ESPixelStick.ino Outdated Show resolved Hide resolved
ESPixelStick/src/service/DisplayOLED.h Outdated Show resolved Hide resolved
platformio.ini Outdated Show resolved Hide resolved
@MartinMueller2003
Copy link
Collaborator

I assume you have some additional discrete components you are putting on the board.
Also, you have not updated the files in the ESPixelStick\dist directory so your platform will never been seen in the flashtool.

MartinMueller2003
MartinMueller2003 requested changes Feb 27, 2024
View reviewed changes
ESPixelStick/src/service/DisplayOLED.cpp Outdated Show resolved Hide resolved
ESPixelStick/src/service/DisplayOLED.cpp Outdated Show resolved Hide resolved
ESPixelStick/src/service/DisplayOLED.cpp Outdated Show resolved Hide resolved
@noman1228
Copy link
Author

Still trying to get a reliable and inexpensive vendor on Amazon for caps and fuse holders... It's just so cheap and fast to iterate through designs with JLCPCB and knowing the end result will need them.
Suggestions for additional discrete?

MartinMueller2003
MartinMueller2003 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@MartinMueller2003 MartinMueller2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I am good with it.

@MartinMueller2003
Copy link
Collaborator

Shelby does the actual merges.

@MartinMueller2003
Copy link
Collaborator

RE Vendors,
I buy from AliExpress and Ebay when I have plenty of time to wait for parts.
I buy from DigiKey and Mouser if I need things fast.
I have bought from Amazon if I need things tomorrow. They tend to be the most expensive option.

@noman1228
Copy link
Author

Obviously I'm nowhere near calling myself a coder and even when I thought I was (a wee young boy) GitHub or basically any version control didn't exist. Do I need to do anything else?

@MartinMueller2003
Copy link
Collaborator

Conflicting files have been resolved. Shelby is the person that controls what goes into main. Your code looks good to me and is now in sync with the latest on main.

@forkineye
Copy link
Owner

It seems to be slightly stale now as there are two conflicts in regards to board definitions. Resolve those and I'll get it merged, thanks.

@forkineye
Copy link
Owner

Looks like platformio.ini has some issues, check the CI run.

@noman1228
Copy link
Author

Must stop attempting to code with my child present....

@noman1228 noman1228 closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinMueller2003 MartinMueller2003 MartinMueller2003 approved these changes

Assignees

@MartinMueller2003 MartinMueller2003

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noman1228 @MartinMueller2003 @forkineye