fix(decision-values): accepted false as a valid decision

w/o losing it to falsy logic
form8ion · Jan 15, 2020 · 8979238 · 8979238
1 parent 08184cc
commit 8979238
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/prompt-test.js b/src/prompt-test.js
@@ -27,8 +27,8 @@ suite('prompt', () => {
   });
 
   test('that decisions are directly included in answers, with those questions excluded from prompts', async () => {
-    const decisions = any.simpleObject();
-    const questionNames = Object.keys(decisions);
+    const questionNames = any.listOf(any.word);
+    const decisions = any.objectWithKeys(questionNames, {factory: any.boolean});
     inquirer.prompt.withArgs(questions).resolves(answers);
 
     assert.deepEqual(

diff --git a/src/prompt.js b/src/prompt.js
@@ -2,7 +2,7 @@ import {prompt} from 'inquirer';
 
 export default async function (questions, decisions = {}) {
   const {filteredQuestions, providedAnswers} = questions.reduce((acc, question) => {
-    if (decisions[question.name]) {
+    if (undefined !== decisions[question.name]) {
       return {
         filteredQuestions: acc.filteredQuestions,
         providedAnswers: {...acc.providedAnswers, [question.name]: decisions[question.name]}