-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update pre-commit and streamline openapi build process #39
Conversation
Add 'openapi' to pre-commit tasks and simplify the Earthfile openapi target by reusing the base image and modifying artifact handling. Removed redundant commands for merging and YAML conversion for increased clarity and efficiency in the build setup.
WalkthroughThe pull request introduces modifications to the project's build and development workflow. The changes primarily affect the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
The `openapi.yaml` file has been deleted from the repository. This file contained the OpenAPI specification for the orchestration service API but is no longer needed. Removing it helps clean up obsolete or unused resources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
flake.nix (1)
100-100
: LGTM! Consider version pinning and documentation.The addition of
yq-go
aligns well with the OpenAPI build process streamlining. However, consider:
- Pinning the version for consistency across development environments
- Adding a comment to document its role in the OpenAPI workflow
Apply this diff to add version pinning and documentation:
- yq-go + # Required for OpenAPI YAML processing in pre-commit checks + yq-go-0_4_51
Add 'openapi' to pre-commit tasks and simplify the Earthfile openapi target by reusing the base image and modifying artifact handling. Removed redundant commands for merging and YAML conversion for increased clarity and efficiency in the build setup.