Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community map embeded html #224

Merged
merged 9 commits into from
Feb 9, 2025
Merged

Community map embeded html #224

merged 9 commits into from
Feb 9, 2025

Conversation

richarddushime
Copy link
Contributor

@richarddushime richarddushime commented Feb 3, 2025

@richarddushime richarddushime requested a review from a team as a code owner February 3, 2025 09:44
@github-actions github-actions bot added the content related Relevant to website content label Feb 3, 2025
@flavioazevedo
Copy link
Contributor

I love this, Richard! Thank you!

Can you make the title: "Forrt community Map" as "FORRT Community Map"?

Also, instead of the note, you can write:

The FORRT Community Map is a visualization tool that illustrates the global reach and diversity of the Framework for Open and Reproducible Research Training (FORRT) community. As of January 2024, this map provides a snapshot of FORRT's members worldwide, highlighting FORRT's extensive international collaboration and its commitment to fostering open and reproducible research practices across various regions. The map underscores FORRT's dedication to inclusivity and its efforts to build a diverse network of scholars, educators, and researchers united in advancing open science principles.

Thank you so much, Richard!

@richarddushime
Copy link
Contributor Author

I have Added a new layout to the community map
looks better now

@flavioazevedo
Copy link
Contributor

Oh man, it seems I have not understood yet how PRs work. I didn't realize there was another PR open on this issue. @LukasWallrich can later tell me how I can do better next time!

In any case, I made a request for how to present the data we have so far, and I linked it in the other PRs, let me know how what's the best way to proceed and I will get it done! Thank you @richarddushime !

@richarddushime
Copy link
Contributor Author

flavio comment

Hi there @richarddushime so sorry for my delay, it seems that there are conflicts for the menu again. My fault! Sorry!
This looks good. I was also wondering if we cannot do something like the amazing folks at PSA: I will paste their map here (I think they do it similar to what we do, but they use Jitter for the points (instead of large circles). I think can display both but theirs is a really nice way too that works best for slides/presentation in my opinion. Super OK if not possible!

image

@richarddushime
Copy link
Contributor Author

My previous comment

Well its nice but I think the one in the PR is better due to features the map has
like the bigger the point the higher the number of people in that area
different colors too

secondly would you also suggest which one we are going to use ?
either the shinny app or the HTML file ???

Then I could focus on improving the selected one

@flavioazevedo
Copy link
Contributor

Just adding here my other comment in another PR:

Hi @richarddushime , can you point me to the html file you are talking about? I am not sure what it is. I love the app for what's worth :)

The suggestion of the picture above is just a way to represent things in a different way. I like the way we do it in the map, but it emphasizes (a lot) Europe, so I am trying to find ways to highlight our diversity. Also, you should know I can be a little 'too much' regarding Visualizations of data: https://flavioazevedo.com/visualizations

@richarddushime
Copy link
Contributor Author

@flavioazevedo this PR has a generated html map same as the shinny app
this is what I was talking about ,

suggested by @LukasWallrich

@flavioazevedo
Copy link
Contributor

Lukas knows far more about these things than I do so if he says we need the html (I am not sure how is that different I still see the map with the same functionalities, which are nice), the so be it. It might be faster to load as Shiny apps are notoriously slow. By the way it says: "This branch is out-of-date with the base branch" so probably it needs some updating. I will try to do that now.

Copy link

github-actions bot commented Feb 9, 2025

👍 All image files/references (if any) are in webp format, in line with our policy.

@richarddushime
Copy link
Contributor Author

@LukasWallrich this PR #226 has fixed the issue, now it's all passing

Copy link
Contributor

@flavioazevedo flavioazevedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Richard, looks great on my end!

@flavioazevedo flavioazevedo merged commit d2c6f84 into master Feb 9, 2025
5 checks passed
@flavioazevedo flavioazevedo deleted the embed-html branch February 9, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content related Relevant to website content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants