Implement Label and FieldSet components + form control updates
#151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nighto
added a commit
that referenced
this pull request
Feb 17, 2025
mkrause
changed the title
Label componentLabel and FieldSet components + form control updates
nighto
reviewed
Feb 19, 2025
nighto
reviewed
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new components:
LabelandFieldSet, corresponding to the native HTML<label>and<fieldset>elements. Additionally, it turnsRadioGroupandCheckboxGroupinto proper form controls, with (1) their own state management, (2) both uncontrolled and controlled usage, and (3) automatically communicating state changes and props likenameandformto the subcomponents through context.Follow ups:
SegmentedControl: add story for controlled usage (plus within a form?)CheckboxTriGroup: Add Group/Field variants ofCheckboxTri? #145