Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix in SEALKEY() #1813

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bugfix in SEALKEY() #1813

wants to merge 1 commit into from

Conversation

NtAlexio2
Copy link
Contributor

This PR fixes a bug found in ntlm.py which calculates invalid seal key for connection-less sessions in smb.
More information can found in MSDN documentations here.

@anadrianmanrique
Copy link
Contributor

Thanks for the PR @NtAlexio2.
Any tip/suggestion on how to test these changes would be more than appreciated, thanks!

@NtAlexio2
Copy link
Contributor Author

Let's review added flags:

  1. NTLMSSP_NEGOTIATE_LM_KEY: This flag disabled by default on Windows Vista and Server 2008. To enable and test this flag you can check MSDN documents
  2. NTLMSSP_NEGOTIATE_DATAGRAM: I'm not sure about scenarios/applications for this one, but you can check documentations here for more information.
  3. NTLMSSP_REVISION_W2K3: Setting this revision level indicates compatibility with features and behaviors introduced in Windows Server 2003. So we should test this one by authenticating against Windows Server 2003.

As a short answer just authenticate to Windows Server 2003. Actually this PR improves backward compatibility.

@anadrianmanrique anadrianmanrique self-assigned this Feb 27, 2025
@anadrianmanrique anadrianmanrique added medium Medium priority item low Low priority item and removed medium Medium priority item labels Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low Low priority item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants