Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generalized eig rwork size #929

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Fix generalized eig rwork size #929

merged 4 commits into from
Jan 30, 2025

Conversation

perazz
Copy link
Member

@perazz perazz commented Jan 30, 2025

Fix #927.

rwork size is different in *GGEV (8*n) vs. in *GEEV (2*n), I had overlooked that.

cc: @jalvesz @jvdp1
Thank you

jvdp1
jvdp1 approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! Thank you @perazz

jalvesz
jalvesz requested changes Jan 30, 2025
View reviewed changes
test/linalg/test_linalg_eigenvalues.fypp Outdated Show resolved Hide resolved
@perazz
Copy link
Member Author

perazz commented Jan 30, 2025

Thanks for the quick review @jvdp1 @jalvesz! I will merge this now as it is better to close the bug earlier rather than later.

@perazz perazz merged commit 036b091 into fortran-lang:master Jan 30, 2025
14 checks passed
@perazz perazz deleted the fix_ggev branch January 30, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalvesz jalvesz jalvesz approved these changes

@jvdp1 jvdp1 jvdp1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"double free or corruption (out)" when requesting eigenvectors in complex generalized eigenvalue problem
3 participants
@perazz @jvdp1 @jalvesz