Testing things with the linter

.github/workflows/pylint.yml

@@ -20,4 +20,4 @@ jobs:
         pip install pylint
     - name: Analysing the code with pylint
       run: |
-        pylint $(git ls-files '*.py') --disable=too-many-instance-attributes,too-many-locals
+        pylint $(git ls-files '*.py') --disable=too-many-instance-attributes,too-many-locals --max-line-length=150

pyzora/game_secret.py

@@ -20,8 +20,13 @@
 You should have received a copy of the GNU General Public
 License along with pyzora. If not, see <https://www.gnu.org/licenses/>.
 """
-from pyzora.secret import *
 import copy as mod_copy
+from pyzora.secret import (BaseSecret, parse_secret, Byte, calculate_checksum,
+                           byte_array_to_string, string_to_byte_array, reverse_substring,
+                           integer_string, reverse_string)
+from pyzora.enums import (TargetGame, ObtainedCompanion, ChildBehaviour,
+                          GameRegion)
+from pyzora.exceptions import SecretError, ChecksumError, NotAGameCodeError
 
 
 class GameSecret(BaseSecret):

pyzora/memory_secret.py

@@ -20,7 +20,11 @@
 You should have received a copy of the GNU General Public
 License along with pyzora. If not, see <https://www.gnu.org/licenses/>.
 """
-from pyzora.secret import *
+from pyzora.secret import (BaseSecret, parse_secret, byte_array_to_string,
+                           string_to_byte_array, reverse_substring, integer_string,
+                           calculate_checksum, reverse_string)
+from pyzora.enums import MemoryEnum, GameRegion, TargetGame
+from pyzora.exceptions import SecretError, ChecksumError, NotAMemoryCodeError
 
 
 class MemorySecret(BaseSecret):
@@ -73,6 +77,7 @@ def __init__(self, *args, **kwargs):
 
     @classmethod
     def load(cls, secret: bytearray | bytes | str, region: GameRegion):
+        """Load a memory secret from bytes or a string."""
         if isinstance(secret, str):
             # Secret string. Parse it before doing anything else.
             # Allows the user to give the region only once

pyzora/ring_secret.py

@@ -20,8 +20,12 @@
 You should have received a copy of the GNU General Public
 License along with pyzora. If not, see <https://www.gnu.org/licenses/>.
 """
-from pyzora.secret import *
-from pyzora.ring_types import *
+from pyzora.secret import (BaseSecret, parse_secret, byte_array_to_string,
+                           calculate_checksum, reverse_string, integer_string,
+                           reverse_substring, string_to_byte_array)
+from pyzora.enums import GameRegion
+from pyzora.exceptions import SecretError, ChecksumError, NotARingCodeError
+from pyzora.ring_types import *  # noqa
 
 
 class RingSecret(BaseSecret):
@@ -73,10 +77,9 @@ def __init__(self, *args, **kwargs):
     def __contains__(self, item):
         if item is NoRings:
             return not self.rings
-        elif item is AllRings:
+        if item is AllRings:
             return self.rings == int(AllRings)
-        else:
-            return (item & self.rings) == item
+        return (item & self.rings) == item
 
     @classmethod
     def load(cls, secret: bytearray | bytes | str, region: GameRegion):
@@ -95,7 +98,7 @@ def load(cls, secret: bytearray | bytes | str, region: GameRegion):
         if (decoded_bytes[14] & 0xF) != (checksum & 0xF):
             raise ChecksumError(f"checksum {checksum} does not match expected value : {decoded_bytes[14]}")
         if decoded_secret[3] != "0" or decoded_secret[4] != "1":
-            raise NotARingCodeError(f"given secret is not a ring code")
+            raise NotARingCodeError("given secret is not a ring code")
         game_id = int(reverse_substring(decoded_secret, 5, 15))
         ring_str = "".join((reverse_substring(decoded_secret, 36, 8),
                             reverse_substring(decoded_secret, 76, 8),
@@ -157,4 +160,3 @@ def to_list(self):
 
     def __hash__(self):
         return hash((self.__game_id, self.__rings))
-