php73: fix builds on darwin architecture

[drupol]

This PR:

• Is related to PHP 7.3 cannot be built #200
• Add a new patch for PHP 7.3 on Darwin architecture

[HelloWorld017]

I'll check whether this builds well on my machine

[HelloWorld017]

This derivation also keeps failing with following issue:

PEAR package PHP_Archive not installed: generated phar will require PHP's phar extension be enabled.

The flag --with-pcre-regex=${prev.pcre2.dev} should be added in order to the php73 to be built.
Here's the commit:

$ git am - <<'EOF'
From ac13f9d341dc63bf366699cfc2911601b73a849b Mon Sep 17 00:00:00 2001
From: nenw <[email protected]>
Date: Fri, 20 Jan 2023 20:00:17 +0900
Subject: [PATCH] php73: fix pcre config flags

---
 pkgs/phps.nix | 1 +
 1 file changed, 1 insertion(+)

diff --git a/pkgs/phps.nix b/pkgs/phps.nix
index 71a884d..760397e 100644
--- a/pkgs/phps.nix
+++ b/pkgs/phps.nix
@@ -43,6 +43,7 @@ let
 
               "--enable-libxml"
               "--with-libxml-dir=${prev.libxml2.dev}"
+              "--with-pcre-regex=${prev.pcre2.dev}"
             ];
 
           buildInputs =
-- 
2.38.1

EOF

[drupol]

Can you try again now?

[drupol]

I pushed a temporary commit (part of #85) to check if it is correctly building on MacOS.
I'll remove it when this PR has been approved, just before merging it.

[drupol]

@HelloWorld017 @shyim Any update here?

[shyim]

shyim in nix-phps on  php73/fix-builds [?] took 5m47s
❯ ./result/bin/php -v
PHP 7.3.28 (cli) (built: Jan 25 2023 08:29:17) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.28, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.3.28, Copyright (c) 1999-2018, by Zend Technologies

whooo works

[HelloWorld017]

Yes, it works on my laptop too. 👍

[drupol]

@jtojnar Should I remove the commit 2ca5c87 before merging? WDYT ?

[jtojnar]

Might be faster to merge it that way, since we would have to review that patch otherwise.

[drupol]

I just removed the commit.

[jtojnar]

Actually, not sure about this. Should not it be versionOlder args.version "7.4"? I would expect newer PHP versions to pick it up using pkg-config.

[drupol]

I'm not sure either, maybe @shyim or @HelloWorld017 knows?

[HelloWorld017]

He is right. It should be applied to php<=7.3 (7.3, 7.2, ...)

You can just add it below to the xml line

[drupol]

Dammit...

[drupol]

I'll open a new PR right now. Sorry about that.