Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Tracy for error handling #1298

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Use Tracy for error handling #1298

wants to merge 3 commits into from

Commits on Dec 25, 2021

  1. Set up content types for all API endpoints 

    If Tracy does not see Content-Type or sees text/html,
it will inject its JavaScript, which breaks tests
that compare response body.
    @jtojnar
    jtojnar committed Dec 25, 2021
    Configuration menu
    Copy the full SHA
    97ad002 View commit details
    Browse the repository at this point in the history

  2. Fix tests on PHP 5.6 

    Since the switch to Tracy, timezone warnings started to occur.
These are no an issue on PHP 7+:
php/doc-en#1238

Also fix path to php.ini.
    @jtojnar
    jtojnar committed Dec 25, 2021
    Configuration menu
    Copy the full SHA
    6980594 View commit details
    Browse the repository at this point in the history

  3. Use Tracy for error handling 

    It offers much nicer error traces and the code is significantly cleaner.

This was the last thing we used F3 framework for.
Now we are officially fat-free-free.

So long and thanks for all the fish.
    @jtojnar
    jtojnar committed Dec 25, 2021
    Configuration menu
    Copy the full SHA
    8a39c10 View commit details
    Browse the repository at this point in the history