client: Middle click on title to open entry in new tab #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for selfoss canceled.
|
This was referenced Nov 23, 2023
|
Related issue: #1411 |
|
I think this makes sense. Using a link might be a bit iffy from accessibility standpoint but then again, we used ARIA |
jtojnar
reviewed
Dec 3, 2023
| className="entry-title-link" | ||
| aria-expanded={expanded} | ||
| aria-current={selected} | ||
| role="link" | ||
| tabIndex="0" |
There was a problem hiding this comment.
This is no longer necessary either.
|
Actually, now I remember why we do not do this. Some spouts (e.g. Twitter) contain links in the title and links cannot be nested. I guess we can fall back to the old way when the title contains |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ten years after #452 (I'm feeling old...) it's time to try again to finally bring this tech-wise tiny but UX-wise major feature to upstream. I'm not aware of any good reason why one should be required to click on the tiny favicon to open an entry in a new tab.
I believe that this should be default behaviour. There's still the possibility to make this an opt-in feature using a new
config.inioption, but I'd strongly discourage it - it's simple and basic, it doesn't affect other users, thus it shouldn't come with unnecessary complexity (like an option).If you want to merge both #1470 and #1471, ignore this PR and merge #1472 instead. Merging any of the three PRs will automatically close the other two PRs.
Closes #1470
Closes #1472