-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for sorting most popular sessions #188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have skipped reviewing this pull request. All of the files are larger than we can process. We're working on it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have skipped reviewing this pull request. Here's why:
- All of the files are larger than we can process. We're working on it!
- It looks like we've already tried to review the commit ff5943b in this pull request and failed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mariobehling, updated as your request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I also realized the "Add to Calendar" option is missing in the mobile version. Please add the icon into the mobile version (without the text "Add to Calendar" next to the version info.
Hi @mariobehling, updated |
Where is the source of src/prhttps://bitbucket.org/hescar/markaz/pull-requests/155etalx/static/agenda/js/pretalx-schedule.js file? Its content in this PR looks like the output of bundle process, not the source. |
Hi @hongquan, pretalx-shedule.js is bundle of this plugin fossasia/eventyay-talk-schedule#12 |
The PR looks Ok, but unfortunately, it includes a code generated by fossasia/eventyay-talk-schedule#12, and the code in eventyay-talk-schedule PR is still in question, I cannot approve this PR yet. |
This PR closes/references issue #161 . It does so by:
How has this been tested?
Checklist