Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes "Implement on/off buttons for Include, Required and Public " #86

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

cbum-dev
Copy link

Implemented Toggle feature for Active status and Public status.
Implemented 3 Toggle feature through button for Required status.

This PR closes/references issue #18 .

Checklist

  • I have added tests to cover my changes.
  • I have updated the documentation.
  • My change is listed in the doc/changelog.rst.

@cbum-dev
Copy link
Author

Screenshot from 2024-03-21 00-35-19

@mariobehling
Copy link
Member

Thank you. This solves the issue on the questions area, but the system has two places for form elements (which is confusing and needs to be solved in another issue). Please also include the area for questions under "content" and change the form elements here as well.

Screenshot from 2024-03-20 21-59-51

@cbum-dev
Copy link
Author

So basically I have to add question form in content page?
Also "but the system has two places for form elements (which is confusing and needs to be solved in another issue)." this is still unclear to me, what you are trying to say?

@mariobehling
Copy link
Member

Please change the following in the Call for Speaker > Content tab.

Do not ask = not Active
Ask, but do not require = Optional
Ask and require = Required

Screenshot from 2024-03-20 23-41-56

Screenshot from 2024-03-20 23-42-19

@cbum-dev
Copy link
Author

Screenshot from 2024-03-21 16-20-44
Is this what you're trying to say?
Or I should add the same buttons like toggling feature their as well ?

@mariobehling
Copy link
Member

Screenshot from 2024-03-20 23-42-19

It should look the same everywhere.

@cbum-dev
Copy link
Author

cbum-dev commented Mar 21, 2024

Screenshot from 2024-03-21 17-58-59
These are form fields So, I dont think their is much more to change the styling of these fields.

@cbum-dev
Copy link
Author

@mariobehling Should I commit this Up?

@mariobehling
Copy link
Member

Thank you. Required and Optional should be the button you created. Active should be as below:

Screenshot from 2024-03-21 19-02-19

As there is no specific reason to make this colorful please keep it in the existing font/graphic colors black and gray.

@cbum-dev
Copy link
Author

Screenshot from 2024-03-22 13-17-27

@mariobehling
Copy link
Member

Updating this branch to include the latest code.

@mariobehling
Copy link
Member

Please post full screenshots of entire pages. The team is currently very busy with the FOSSASIA Summit and we cannot test locally all the time. Appreciate if for making it easier! If we see an issue already in a screenshot we dont have to spend time on deploying.

@mariobehling
Copy link
Member

Please post screenshots of a) relevant content page section b) relevant questions page section. These two sections should be as close as possible in regards to design and functionality. I understand that there are currently still differences though.

@cbum-dev
Copy link
Author

Please post full screenshots of entire pages. The team is currently very busy with the FOSSASIA Summit and we cannot test locally all the time. Appreciate if for making it easier! If we see an issue already in a screenshot we dont have to spend time on deploying.

I understand and thank you for responding.
Pushing it as soon as possible.

@cbum-dev
Copy link
Author

cbum-dev commented Mar 23, 2024

Screenshot from 2024-03-23 16-53-29

This is the Question Page.

Screenshot from 2024-03-23 16-53-19

This is the content page. But this seems to be little off as this is both for viewing content and editing content unlike the question page.

Screenshot from 2024-03-23 16-53-52

This is the question edit page. Where One can edit the question. So considering by the design perspective the content page should be like this or we can create a separate content view page, where we can implement the button like feature for toggling and that will be one step close to same in terms of feature as well as functionality.
Rest I'm still open to what's your take regarding this.
If You're liking this look of content page i'll push that code too.

@mariobehling
Copy link
Member

mariobehling commented Mar 23, 2024

Is it possible to stick with the same kind of buttons everywhere?

316237676-c05bc423-1727-4f01-87df-5db8dae9450f

@cbum-dev
Copy link
Author

Screenshot from 2024-03-23 19-28-21
So you are saying to have buttons for required and optional , and for not active i should add a toggle?
Or I'm still getting it in wrong direction.

@mariobehling
Copy link
Member

As much as possible same design everywhere. Please add an active toggle into the content page as well.

Screenshot from 2024-03-23 16-53-29

@mariobehling
Copy link
Member

Please make the content page as much as possible as the questions page.

@cbum-dev
Copy link
Author

Please make the content page as much as possible as the questions page.

Now I have got what to do. Previously I was confused about the feature.
Thanks for clarifying.
Started working on it. Will push the changes as early as possible.

@cbum-dev
Copy link
Author

Screenshot from 2024-03-24 22-58-08
Their is still some leverage left to add buttons for required instead of options form element.
Please look at this and provide some conclusion regarding this,

@mariobehling
Copy link
Member

Similar to the previous eventyay version please only offer a) optional and required on the left and b) a button for active non-active. Is that possible?

@mariobehling
Copy link
Member

I recommend to you to have a look at https://eventyay.com and test this feature by creating an event and enabling call for speakers in the last step. There is an option "include" which is the same as active/inactive.

@cbum-dev
Copy link
Author

Screenshot from 2024-03-25 00-57-58

@cbum-dev
Copy link
Author

I recommend to you to have a look at https://eventyay.com and test this feature by creating an event and enabling call for speakers in the last step. There is an option "include" which is the same as active/inactive.

What's name of that repo ?

@mariobehling
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants