feat: View social links in event details #105

dreadpool2 · 2018-06-08T16:01:13Z

Fixes #95

dreadpool2 · 2018-06-09T09:20:16Z

@nikit19 @simarsingh24 @iamareebjamal I made some social links using the API, Should I change the UI or just keep it like this ?

nikit19

Have a look at Eventbrite's UI and try to make it like that

dreadpool2 · 2018-06-09T23:07:28Z

@iamareebjamal We can only have the UI as same to Eventbrite after issue #106 is taken care of. Meanwhile changed the colour to grey

iamareebjamal · 2018-06-10T06:19:15Z

app/src/main/java/org/fossasia/openevent/general/social/SocialLink.kt

+        @Id(IntegerIdHandler::class)
+        val id: Int,
+        val link: String,
+        val name: String


Add foreign key

iamareebjamal · 2018-06-10T06:19:38Z

app/src/main/java/org/fossasia/openevent/general/social/SocialLinksDao.kt

+    fun deleteAll()
+
+    @Query("SELECT * from SocialLink ORDER BY startsAt DESC")
+    fun getAllSocialLinks(id: Long): Flowable<List<SocialLink>>


Wrong logic, should get social links for an event

Yeah Actually I haven't implemented db storage yet, I am doing it 👍

dreadpool2 · 2018-06-12T07:12:12Z

@iamareebjamal Added type converter and it is compiling correctly, but the fetching and storing is not working

iamareebjamal · 2018-06-12T07:43:10Z

app/src/main/java/org/fossasia/openevent/general/social/SocialLink.kt

+        val link: String,
+        val name: String,
+        @Relationship("event")
+        var event: Event?


Why var and nullable?

I was facing an error which gave that parameter specified as non-null is null

This means that response is not receiving event as relationship. Fix that instead of removing this

that is because you havent added include event statement inside the API

Its still returning that error, event is always null

Check the logs for why is that

Yeah I did check, it like the jackson mapping is not done properly

java.lang.RuntimeException: com.fasterxml.jackson.databind.JsonMappingException: Instantiation of [simple type, class org.fossasia.openevent.general.social.SocialLink] value failed (java.lang.IllegalArgumentException): Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkParameterIsNotNull, parameter event 06-12 18:08:18.409 32538-32538/org.fossasia.openevent.general E/SocialLinksViewModel$loadSocialLinks:

Create a new type called EventId which only contains id attribute and use it instead of whole Event

feat: make converter for event

dreadpool2 · 2018-06-12T13:39:01Z

@iamareebjamal seemingly after doing even that the loading is failing :(

dreadpool2 · 2018-06-12T13:41:04Z

06-12 19:04:25.801 15162-15162/org.fossasia.openevent.general E/SocialLinksViewModel$loadSocialLinks: java.lang.RuntimeException: com.fasterxml.jackson.databind.JsonMappingException: Instantiation of [simple type, class org.fossasia.openevent.general.social.SocialLink] value failed (java.lang.IllegalArgumentException): Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkParameterIsNotNull, parameter eventId

iamareebjamal · 2018-06-12T16:11:37Z

Name should be event

iamareebjamal · 2018-06-12T16:15:25Z

First resolve conflicts so that PR can be locally inspected

dreadpool2 · 2018-06-12T16:32:53Z

@iamareebjamal Resolved conflicts

simarsingh24 · 2018-06-12T16:40:08Z

app/src/main/java/org/fossasia/openevent/general/di/Modules.kt

@@ -89,7 +96,7 @@ val networkModule = applicationContext {
        Retrofit.Builder()
                .client(get())
                .addCallAdapterFactory(RxJava2CallAdapterFactory.create())
-                .addConverterFactory(JSONAPIConverterFactory(objectMapper, Event::class.java, User::class.java, SignUp::class.java, Ticket::class.java))
+                .addConverterFactory(JSONAPIConverterFactory(objectMapper, Event::class.java, User::class.java, SignUp::class.java, Ticket::class.java, SocialLink::class.java, EventId::class.java))


@iamareebjamal why is eventid class here would it be needed?

dreadpool2 · 2018-06-12T17:09:41Z

The mapping is still not being done correctly though it looks quite correct.
06-12 22:02:21.908 5808-5808/org.fossasia.openevent.general E/SocialLinksViewModel$loadSocialLinks: java.lang.RuntimeException: com.fasterxml.jackson.databind.JsonMappingException: Instantiation of [simple type, class org.fossasia.openevent.general.social.SocialLink] value failed (java.lang.IllegalArgumentException): Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkParameterIsNotNull, parameter event

iamareebjamal · 2018-06-12T17:14:31Z

I'm looking at it

iamareebjamal · 2018-06-12T17:31:50Z

@dreadpool2 Which event has social links

dreadpool2 · 2018-06-12T17:32:47Z

seminar on functional programming

dreadpool2 · 2018-06-12T18:38:45Z

@iamareebjamal Did it work after making it nullable ?

dreadpool2 · 2018-06-12T19:03:33Z

@iamareebjamal Wow! I checked it out it seems to work really fine 👍

iamareebjamal · 2018-06-12T19:07:48Z

app/src/main/java/org/fossasia/openevent/general/social/SocialLink.kt

 data class SocialLink(
        @Id(IntegerIdHandler::class)
        @PrimaryKey
        val id: Int,
        val link: String,
        val name: String,
+        @ColumnInfo(index = true)
+        @ForeignKey(entity = Event::class, parentColumns = ["id"], childColumns = ["event"], onDelete = CASCADE, onUpdate = CASCADE)


Not sure why this foreign key does not work, please revert back to your method of declaring foreign key

Okay will do that 👍 Was the error due to ColumnInfo ?

No, JSONAPI converter can't set relationship at the time of creation of entity

Ohhkay !! I verified that now 👍 So nullable made the difference

iamareebjamal · 2018-06-12T19:08:35Z

app/src/main/java/org/fossasia/openevent/general/EventConverter.kt

+import org.fossasia.openevent.general.event.EventId
+import timber.log.Timber
+
+class EventConverter {


Move to correct package

dreadpool2 · 2018-06-12T19:37:31Z

Did the changes 👍

dreadpool2 · 2018-06-13T15:19:33Z

@iamareebjamal Are any other changes required ?

iamareebjamal · 2018-06-13T15:31:27Z

app/src/main/java/org/fossasia/openevent/general/event/EventConverter.kt

+
+import android.arch.persistence.room.TypeConverter
+
+class EventConverter {


EventIdConverter

iamareebjamal · 2018-06-13T15:32:22Z

app/src/main/java/org/fossasia/openevent/general/social/SocialLinksService.kt

+
+class SocialLinksService(private val socialLinkApi: SocialLinkApi, private val socialLinksDao: SocialLinksDao) {
+
+    fun getSocialLinks(id: Long): Single<List<SocialLink>> {


Should return flowable

@iamareebjamal We used Single in all the previous cases, should we still use Flowable ?

@iamareebjamal Should it remain as Single?

We are always using Flowable AFAIK

Actually in the discount codes fetching we use Single, even when dealing with users we are using Single actually.

Okay I think I understood 👍

iamareebjamal · 2018-06-13T15:33:22Z

Always remove he wip tag once the PR is finalized

dreadpool2 · 2018-06-14T06:30:09Z

PR Updated

iamareebjamal · 2018-06-14T06:40:29Z

app/schemas/org.fossasia.openevent.general.OpenEventDatabase/1.json

    "entities": [
      {
        "tableName": "Event",
-        "createSql": "CREATE TABLE IF NOT EXISTS `${TABLE_NAME}` (`id` INTEGER NOT NULL, `name` TEXT NOT NULL, `identifier` TEXT NOT NULL, `startsAt` TEXT NOT NULL, `endsAt` TEXT NOT NULL, `timezone` TEXT NOT NULL, `privacy` TEXT NOT NULL, `paymentCountry` TEXT, `paypalEmail` TEXT, `thumbnailImageUrl` TEXT, `schedulePublishedOn` TEXT, `paymentCurrency` TEXT, `organizerDescription` TEXT, `originalImageUrl` TEXT, `onsiteDetails` TEXT, `organizerName` TEXT, `largeImageUrl` TEXT, `deletedAt` TEXT, `ticketUrl` TEXT, `locationName` TEXT, `codeOfConduct` TEXT, `state` TEXT, `searchableLocationName` TEXT, `description` TEXT, `pentabarfUrl` TEXT, `xcalUrl` TEXT, `logoUrl` TEXT, `externalEventUrl` TEXT, `iconImageUrl` TEXT, `icalUrl` TEXT, `createdAt` TEXT, `bankDetails` TEXT, `chequeDetails` TEXT, `isComplete` INTEGER NOT NULL, `latitude` REAL, `longitude` REAL, `canPayByStripe` INTEGER NOT NULL, `canPayByCheque` INTEGER NOT NULL, `canPayByBank` INTEGER NOT NULL, `canPayByPaypal` INTEGER NOT NULL, `canPayOnsite` INTEGER NOT NULL, `isSponsorsEnabled` INTEGER NOT NULL, `hasOrganizerInfo` INTEGER NOT NULL, `isSessionsSpeakersEnabled` INTEGER NOT NULL, `isTicketingEnabled` INTEGER NOT NULL, `isTaxEnabled` INTEGER NOT NULL, `isMapShown` INTEGER NOT NULL, PRIMARY KEY(`id`))",
+        "createSql": "CREATE TABLE IF NOT EXISTS `${TABAuLE_NAME}` (`id` INTEGER NOT NULL, `name` TEXT NOT NULL, `identifier` TEXT NOT NULL, `startsAt` TEXT NOT NULL, `endsAt` TEXT NOT NULL, `timezone` TEXT NOT NULL, `privacy` TEXT NOT NULL, `paymentCountry` TEXT, `paypalEmail` TEXT, `thumbnailImageUrl` TEXT, `schedulePublishedOn` TEXT, `paymentCurrency` TEXT, `organizerDescription` TEXT, `originalImageUrl` TEXT, `onsiteDetails` TEXT, `organizerName` TEXT, `largeImageUrl` TEXT, `deletedAt` TEXT, `ticketUrl` TEXT, `locationName` TEXT, `codeOfConduct` TEXT, `state` TEXT, `searchableLocationName` TEXT, `description` TEXT, `pentabarfUrl` TEXT, `xcalUrl` TEXT, `logoUrl` TEXT, `externalEventUrl` TEXT, `iconImageUrl` TEXT, `icalUrl` TEXT, `createdAt` TEXT, `bankDetails` TEXT, `chequeDetails` TEXT, `isComplete` INTEGER NOT NULL, `latitude` REAL, `longitude` REAL, `canPayByStripe` INTEGER NOT NULL, `canPayByCheque` INTEGER NOT NULL, `canPayByBank` INTEGER NOT NULL, `canPayByPaypal` INTEGER NOT NULL, `canPayOnsite` INTEGER NOT NULL, `isSponsorsEnabled` INTEGER NOT NULL, `hasOrganizerInfo` INTEGER NOT NULL, `isSessionsSpeakersEnabled` INTEGER NOT NULL, `isTicketingEnabled` INTEGER NOT NULL, `isTaxEnabled` INTEGER NOT NULL, `isMapShown` INTEGER NOT NULL, PRIMARY KEY(`id`))",


TABAuLE_NAME typo

dreadpool2 · 2018-06-14T07:13:42Z

PR Updated

iamareebjamal · 2018-06-14T08:38:18Z

app/src/main/java/org/fossasia/openevent/general/social/SocialLinksViewModel.kt

+                .observeOn(AndroidSchedulers.mainThread())
+                .doOnSubscribe({
+                    progress.value = true
+                }).doOnNext({


It's not working with doFinally

Progress is never complete

Sanyog Ghosh added 4 commits June 8, 2018 00:30

organised ticket files to a folder and added social-link api and model

c6505c8

(wip) feat: view social links in event details

1060ef5

corrected the loading of social links

c148792

minor changes to social links ui

5f7c7bb

added entry/exit animations and changed close button icon

60fd583

nikit19 reviewed Jun 9, 2018

View reviewed changes

feat: Changed the icon colours to grey and recycler background to white

10c2185

iamareebjamal reviewed Jun 10, 2018

View reviewed changes

feat: Add type converter for event

5c1ca37

iamareebjamal reviewed Jun 12, 2018

View reviewed changes

Sanyog Ghosh added 2 commits June 12, 2018 17:49

feat: make converter for event

4dbb867

feat: make converter for event

feat: add eventid class

8927662

Merge branch 'development' into social_links

1b052ac

simarsingh24 reviewed Jun 12, 2018

View reviewed changes

fix: Make relationship nullable

78b359a

fix: made type converter for event alone

7c2b03f

iamareebjamal reviewed Jun 12, 2018

View reviewed changes

Sanyog Ghosh added 2 commits June 13, 2018 01:00

fix: remove unused imports and add foreign key

db8a87e

merge fix

c77acd7

s

b607085

iamareebjamal requested changes Jun 13, 2018

View reviewed changes

dreadpool2 changed the title ~~(wip) feat: view social links in event details~~ feat: View social links in event details Jun 13, 2018

fix: Change single to flowable and refactor file names

2db574c

iamareebjamal reviewed Jun 14, 2018

View reviewed changes

fix : table name typo fixed

acd7340

Sanyog Ghosh and others added 2 commits June 14, 2018 13:05

fix : change method names

120939f

Merge branch 'development' into social_links

b554527

iamareebjamal reviewed Jun 14, 2018

View reviewed changes

iamareebjamal approved these changes Jun 14, 2018

View reviewed changes

iamareebjamal merged commit a2b093e into fossasia:development Jun 14, 2018


		import android.arch.persistence.room.TypeConverter

		class EventConverter {


		class SocialLinksService(private val socialLinkApi: SocialLinkApi, private val socialLinksDao: SocialLinksDao) {

		fun getSocialLinks(id: Long): Single<List<SocialLink>> {

feat: View social links in event details #105

feat: View social links in event details #105

Conversation

dreadpool2 commented Jun 8, 2018 • edited Loading

dreadpool2 commented Jun 9, 2018 • edited Loading

nikit19 left a comment

Choose a reason for hiding this comment

dreadpool2 commented Jun 9, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dreadpool2 commented Jun 12, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dreadpool2 commented Jun 12, 2018

dreadpool2 commented Jun 12, 2018

iamareebjamal commented Jun 12, 2018

iamareebjamal commented Jun 12, 2018

dreadpool2 commented Jun 12, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dreadpool2 commented Jun 12, 2018

iamareebjamal commented Jun 12, 2018

iamareebjamal commented Jun 12, 2018

dreadpool2 commented Jun 12, 2018

dreadpool2 commented Jun 12, 2018

dreadpool2 commented Jun 12, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dreadpool2 commented Jun 12, 2018

dreadpool2 commented Jun 13, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iamareebjamal commented Jun 13, 2018

dreadpool2 commented Jun 14, 2018

Choose a reason for hiding this comment

dreadpool2 commented Jun 14, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dreadpool2 commented Jun 8, 2018 •

edited

Loading

dreadpool2 commented Jun 9, 2018 •

edited

Loading