fix: Administrative area in Location Detection #2637
Conversation
dheerajkotwani
changed the title
dheerajkotwani
changed the title
| object : LocationListener { | ||
| override fun onLocationChanged(location: Location?) { | ||
| if (location == null) { | ||
| emitter.onError(java.lang.IllegalStateException()) |
There was a problem hiding this comment.
Given for the condition if incase it fails to update location to the variable then it gives the error for it
There was a problem hiding this comment.
I can't see that message in IllegalStateException constructor. How would I know?
There was a problem hiding this comment.
should I remove the it? or I had a question is there need of AdminArea if we are implementing it using cityName if not then should I change the method for calling the admin area with the city name as it will also save from creating another function for it?
There was a problem hiding this comment.
No, you should throw error with a proper message
There was a problem hiding this comment.
okay, I will fix it soon
| ?: return Single.error(IllegalStateException()) | ||
| val geoCoder = Geocoder(context, Locale.getDefault()) | ||
|
|
||
| return Single.create { emitter -> |
There was a problem hiding this comment.
This will create a memory leak when Single is cancelled. Add logic to handle the cancellation
Fixes #2459 The location is not displayed properly
Changes:
Previously on clicking on detect my location it showed the Administrative Area made it to display the City Name as it would be more specific.
Screenshots for the change:
Previously
After Changing
