Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-9051: When selected an option on Text Rotate but it displayed wro… #9052

Merged
merged 25 commits into from Aug 21, 2023
Merged

Conversation

ghost
Copy link

@ghost ghost commented Aug 8, 2023

…ng on PDF file

Fixes #fossasia/open-event-frontend#9051

Short description of what this resolves:

  • When selected an option on Text Rotate but it displayed wrong on PDF file

Changes proposed in this pull request:

  • When selected an option on Text Rotate but it displayed wrong on PDF file

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@khangon
Copy link
Contributor

khangon commented Aug 11, 2023

Hi @norbusan , @mariobehling , @cweitat ,
We have completed ticket fossasia/open-event-frontend#9051
Please help me check and verify.
Thanks,

Screenshot from 2023-08-11 08-47-34

@ghost ghost marked this pull request as ready for review August 11, 2023 01:50
@mariobehling
Copy link
Member

Thanks. Please resolve conflicts.

mariobehling
mariobehling previously approved these changes Aug 11, 2023
@nnhathung

This comment was marked as resolved.

@mariobehling mariobehling merged commit 1f76855 into fossasia:development Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants