Add missing __init__.py files & let setup.py find all importable packages on its own #879
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the recent refactoring in #858 I've missed to tell
setup.py
about the new python directories.This results in visdom to be effectively broken when installed from
pip
orsetup.py
.The solution is quite easy:
__init__.py
filessetup.py
about the new directories. I have solved this by using the automaticsetuptools.find_packages
method.This should also solve #878, who has pointed out the error.
How Has This Been Tested?
Running locally
python setup.py install --user
works now as expected.Note
Maybe it would be best to install visdom using
setup.py
for all tests so this does not happen again?Types of changes
Checklist:
py/visdom/VERSION
according to Semantic VersioningA nothing has changed really, I added a
.post1
to the version.