feat: updated project structure and added basic test cases to project #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-avy
force-pushed
the
kavya/api/test
branch
4 times, most recently
from
c9e5795 to
fc71c22
Compare
k-avy
force-pushed
the
kavya/api/test
branch
3 times, most recently
from
67389b1 to
bec1cda
Compare
|
There can be some more changes in the project structure, let's go over it in our next call. |
k-avy
force-pushed
the
kavya/api/test
branch
2 times, most recently
from
1cb00d7 to
2929585
Compare
updated project structure to avoid import cycle
added a different package for database where:
there is function related to migration of database
and populating database
added basic test cases:
added API test cases for create, update, get license by shortname and search in licenses
added user test cases for create and get user by id
updated meta to pagination meta for better discription
Signed-off-by: Kavya Shukla <[email protected]>
avinal
suggested changes
Aug 21, 2023
Comment on lines
+26
to
+27
| r.POST("/api/search", SearchInLicense) | ||
| r.GET("/api/licenses", FilterLicense) |
There was a problem hiding this comment.
Create an issue to merge these two endpoints into a single one.
| @@ -56,7 +56,7 @@ type LicenseJson struct { | |||
| // license retrieval operation. | |||
| // It contains information that provides context and supplementary details | |||
| // about the retrieved license data. | |||
| type Meta struct { | |||
| type PaginationMeta struct { | |||
There was a problem hiding this comment.
Create an issue to make this struct as free form key-value mapping field
Co-authored-by: Avinal Kumar <[email protected]> Signed-off-by: Gaurav Mishra <[email protected]>
GMishx
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: updated the project structure and added test case
updated project structure to avoid import cycle
added basic test cases:
updated meta to pagination meta for better discription