Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): use JWT tokens #32

Merged
merged 3 commits into from
Jan 11, 2024
Merged

feat(auth): use JWT tokens #32

merged 3 commits into from
Jan 11, 2024

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented Jan 5, 2024

Change the authentication flow of the application.

  1. Use bcrypt to encrypt the passwords in DB.
  2. New endpoint /login to generate JWT tokens for authentication.
  3. Use JWT tokens in Authorization header for authenticating user.

Closes #1

@GMishx GMishx requested review from avinal and k-avy January 5, 2024 09:53
avinal
avinal reviewed Jan 5, 2024
View reviewed changes
Copy link
Member

@avinal avinal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Will test in the weekend.

avinal
avinal approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@avinal avinal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Working as expected.

@GMishx GMishx mentioned this pull request Jan 11, 2024
Merged
@GMishx GMishx merged commit ee4be56 into main Jan 11, 2024
4 checks passed
@GMishx GMishx deleted the feat/auth/jwt branch January 11, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avinal avinal avinal approved these changes

@k-avy k-avy Awaiting requested review from k-avy

Assignees

@ag4ums ag4ums

Labels
needs code review needs test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Basic endpoint requirements
3 participants
@GMishx @avinal @ag4ums