Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): Github Workflow for Golang static checks and linting #36

Merged
merged 1 commit into from
Jan 12, 2024
Merged

feat(ci): Github Workflow for Golang static checks and linting #36

merged 1 commit into from
Jan 12, 2024

Conversation

dvjsharma
Copy link
Contributor

@dvjsharma dvjsharma commented Jan 11, 2024 •
edited
Loading

Description

Added Github Workflow for Golang static checks and linting
completes #33

Note: To be merged once the codebase is error-free. following are the current errors:

Screenshot from 2024-01-11 17-25-33

Merge after #38

CC @avinal @GMishx

@dvjsharma dvjsharma mentioned this pull request Jan 11, 2024
Closed
@dvjsharma dvjsharma force-pushed the feat/issue-33 branch 3 times, most recently from df4341f to 61f6e21 Compare January 11, 2024 13:06
@dvjsharma dvjsharma mentioned this pull request Jan 11, 2024
Merged
@dvjsharma
Copy link
Contributor Author

Tested on a remote instance, working as expected after merge of #38

image

@dvjsharma dvjsharma requested a review from GMishx January 11, 2024 20:09
@GMishx
Copy link
Member

GMishx commented Jan 12, 2024

Hey @dvjsharma , since #38 is merged, please rebase the branch.

Also, the repo requires signed commits. Please sign the commit before pushing.

@dvjsharma
Copy link
Contributor Author

Hi @GMishx, I've completed the rebase and signed the commit. The check has passed successfully. PTAL

GMishx
GMishx approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMishx
Copy link
Member

GMishx commented Jan 12, 2024

I don't see the commit is signed
image

It should have the Verified tag like this image

avinal
avinal suggested changes Jan 12, 2024
View reviewed changes
Copy link
Member

@avinal avinal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good to me. FYI, we can still customize this using a YAML config.

https://github.com/golangci/golangci-lint-action/blob/3efd423e8d927ea4a8725c50c8ab863118547ad5/README.md?plain=1#L57-L61

.github/workflows/golangci.yml Outdated Show resolved Hide resolved
.github/workflows/golangci.yml Outdated Show resolved Hide resolved
@dvjsharma dvjsharma force-pushed the feat/issue-33 branch 2 times, most recently from 6607f19 to 58ea840 Compare January 12, 2024 08:22
@dvjsharma
Copy link
Contributor Author

Hi @avinal, I've made the requested changes for the commit signature, tool version, and newline. PTAL.

P.S. Sorry for the delay i wasn't familiar about GPG Keys so it took time to configure :)

CC @GMishx

@dvjsharma dvjsharma requested a review from avinal January 12, 2024 08:33
@GMishx GMishx merged commit a0f7261 into fossology:main Jan 12, 2024
5 checks passed
@GMishx GMishx mentioned this pull request Jan 12, 2024
Closed
@dvjsharma dvjsharma mentioned this pull request Jan 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMishx GMishx GMishx approved these changes

@avinal avinal Awaiting requested review from avinal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dvjsharma @GMishx @avinal