Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add /export endpoint, To export All License Json #52

Merged
merged 1 commit into from
May 20, 2024
Merged

Feat: Add /export endpoint, To export All License Json #52

merged 1 commit into from
May 20, 2024

Conversation

Kaushl2208
Copy link
Member

image
image

GMishx
GMishx requested changes May 6, 2024
View reviewed changes
pkg/api/licenses.go Outdated Show resolved Hide resolved
pkg/api/licenses.go Outdated Show resolved Hide resolved
pkg/api/licenses.go Outdated Show resolved Hide resolved
pkg/api/licenses.go Outdated Show resolved Hide resolved
pkg/api/licenses.go Outdated Show resolved Hide resolved
pkg/api/licenses.go Outdated Show resolved Hide resolved
avinal
avinal suggested changes May 6, 2024
View reviewed changes
Copy link
Member

@avinal avinal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes, AFIR the docs are generated so regenerating after changes will fix them as well.

pkg/api/licenses.go Outdated Show resolved Hide resolved
pkg/api/licenses.go Outdated Show resolved Hide resolved
pkg/api/licenses.go Outdated Show resolved Hide resolved
avinal
avinal reviewed May 6, 2024
View reviewed changes
pkg/api/api.go Outdated Show resolved Hide resolved
@Kaushl2208 Kaushl2208 requested a review from GMishx May 6, 2024 08:00
GMishx
GMishx approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@GMishx
Copy link
Member

GMishx commented May 13, 2024

@Kaushl2208 please squash the commits and sign them with you keys.

GMishx
GMishx requested changes May 13, 2024
View reviewed changes
pkg/api/licenses.go Outdated Show resolved Hide resolved
@Kaushl2208
Copy link
Member Author

image

Changed the filename :)

@Kaushl2208 Kaushl2208 force-pushed the feat/export-license branch from ed157f5 to aff229d Compare May 15, 2024 08:43
GMishx
GMishx approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GMishx
GMishx approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected.

@GMishx
Copy link
Member

GMishx commented May 20, 2024

@Kaushl2208 can you please fix the commit message and sign the commits so we can merge your PR?

Learn more about signing commits.

@Kaushl2208
feat(license): add /export endpoint
f501e39 
Signed-off-by: Kaushlendra Pratap Singh <[email protected]>
@Kaushl2208 Kaushl2208 force-pushed the feat/export-license branch from aff229d to f501e39 Compare May 20, 2024 09:23
@GMishx GMishx merged commit 8892802 into fossology:main May 20, 2024
5 checks passed
@GMishx GMishx mentioned this pull request May 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avinal avinal avinal requested changes

@GMishx GMishx GMishx approved these changes

Assignees
No one assigned
Labels
merge conflict
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kaushl2208 @GMishx @avinal