Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(obligation_maps): Add transactions and refactor code #61

Merged
merged 1 commit into from
Jun 3, 2024
Merged

refactor(obligation_maps): Add transactions and refactor code #61

merged 1 commit into from
Jun 3, 2024

Conversation

deo002
Copy link
Collaborator

@deo002 deo002 commented May 21, 2024

Code Changes Overview

  • Added error handling and transactions whereever required.
  • Seperated the logic of calculating diff from the obligation maps list in database and the list provided by the user to determine the licenses to be inserted and the licenses to be removed into function GenerateDiffOfLicenses.
  • Made PerformObligationMapActions a global function.
  • PerformObligationMapActions and GenerateDiffOfLicenses can be reused in ImportObligations function.

@deo002 deo002 requested a review from GMishx May 21, 2024 11:04
GMishx
GMishx approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMishx GMishx merged commit 51e67b4 into fossology:main Jun 3, 2024
7 checks passed
@GMishx GMishx deleted the obligation_maps branch June 3, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMishx GMishx GMishx approved these changes

Assignees
No one assigned
Labels
needs test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deo002 @GMishx