Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Docker Support for license DB #64

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Feat: Docker Support for license DB #64

merged 1 commit into from
Jun 6, 2024

Conversation

Kaushl2208
Copy link
Member

@Kaushl2208 Kaushl2208 commented May 31, 2024 •
edited by GMishx
Loading

  1. Dockerfile --> Multi Build stage for LicenseDB application
  2. docker-compose.yml --> Orchestrate Postgres and Application (LicenseDB)

To Test:

docker compose build
docker compose up -d

Closes #63

@Kaushl2208 Kaushl2208 force-pushed the feat/docker-support branch from e00e8e6 to 8c1fa00 Compare June 3, 2024 16:30
@Kaushl2208
Copy link
Member Author

@GMishx Can you review :)

GMishx
GMishx approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good, needs test.

Thanks for the contribution.

GMishx
GMishx requested changes Jun 4, 2024
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
@Kaushl2208
feat: Docker Support for license DB
d4f8f4f 
Signed-off-by: Kaushlendra Pratap Singh <[email protected]>
@Kaushl2208 Kaushl2208 force-pushed the feat/docker-support branch from c14f9bb to d4f8f4f Compare June 5, 2024 16:01
avinal
avinal approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@avinal avinal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected.

Possible next steps: GitHub Actions for pushing images to GitHub/Docker registry on push/release.

GMishx
GMishx approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@GMishx GMishx removed the needs test label Jun 6, 2024
@GMishx GMishx merged commit 3bbf2d8 into fossology:main Jun 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avinal avinal avinal approved these changes

@GMishx GMishx GMishx approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Orchestration: LicenseDb needs docker support
3 participants
@Kaushl2208 @GMishx @avinal