Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: add pull request template #65

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

avinal
Copy link
Member

@avinal avinal commented Jun 3, 2024

Changes

  • Added pull request to encourage best contribution practices.

Signed-off-by: Avinal Kumar [email protected]

Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add section for issue with the Closes.

And please add a license header to the file, the checks are failing 😬

@GMishx
Copy link
Member

GMishx commented Jun 3, 2024

@avinal please follow the conventional commit messages.

- Added pull request to encourage best contribution practices.

Signed-off-by: Avinal Kumar <[email protected]>
@avinal avinal force-pushed the avinal/templates branch from ce0b08b to 600d240 Compare June 4, 2024 07:33
@avinal avinal changed the title Add pull request template misc: add pull request template Jun 4, 2024
@avinal
Copy link
Member Author

avinal commented Jun 4, 2024

Maybe add section for issue with the Closes.

Added as part of the changes.

@GMishx GMishx merged commit ba3eed5 into fossology:main Jun 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants