Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(license_obligations): Add type field to response #71

Merged
merged 1 commit into from
Jun 18, 2024
Merged

fix(license_obligations): Add type field to response #71

merged 1 commit into from
Jun 18, 2024

Conversation

deo002
Copy link
Collaborator

@deo002 deo002 commented Jun 7, 2024

Changes

  • Add type field to reponse of /obligation_maps/license/{license}. It is needed for display in UI.

Submitter Checklist

  • Includes tests (if there is a feature changed/added)
  • Includes docs ( if changes are user facing)
  • I have tested my changes locally.

References

image

@deo002 deo002 requested a review from GMishx June 7, 2024 11:24
GMishx
GMishx approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

GMishx
GMishx approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected.

@GMishx GMishx removed the needs test label Jun 18, 2024
@GMishx GMishx merged commit 7940f0a into fossology:main Jun 18, 2024
7 checks passed
@GMishx GMishx deleted the license_obligations branch June 18, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMishx GMishx GMishx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deo002 @GMishx