refactor(obligations): Make separate database tables for classification and type

[deo002]

Changes

• Make separate database tables for classification and type. They are not a fixed set of values. We can add/remove the possible classification and type for obligation. Support for this functionality will be added in future PRs.
• Use GORM notation for many-to-many relationship of obligation maps.
• While converting from the new Obligation struct to json, the classification, type and shortnames were not being marshalled in the desired format. So wrote custom marshaller and unmarshaller for it. We could have used Converter functions too, same effort would be required.
• Added BeforeCreate and BeforeUpdate hook for data validation(non empty strings for topic, text, unique topic and text, valid classification and type values etc).
• Deleted optional data type wrappers as they are no longer needed.

Submitter Checklist

• Includes tests (if there is a feature changed/added)
• Includes docs ( if changes are user facing)
• I have tested my changes locally.

References

[GMishx]

Changes looks good. Needs test

[avinal]

Few nitpicks, looks good to me.

[avinal]

Good one

[avinal]

I would highly recommend moving all functions out of this file. Probably in the same package but a different file. It somewhat undermines the structure of the project.

Not a blocker.

[deo002]

Yes. What do you think about moving a GORM struct and all it's methods into separate files? Like one for licenses, one for obligations etc.
I'll do it in another PR, this one's already big.

[avinal]

This is a good idea, under models package, you can separate them into differnt files.

[GMishx]

For existing database, these new columns should hold some default values:

LicenseDb/laas -dbname laas -datafile fossology/install/db/licenseRef.json -populatedb true

2024/10/18 10:33:40 LicenseDb/cmd/laas/main.go:53 ERROR: column "obligation_classification_id" of relation "obligations" contains null values (SQLSTATE 23502)
[0.252ms] [rows:0] ALTER TABLE "obligations" ADD "obligation_classification_id" bigint NOT NULL
2024/10/18 10:33:40 Failed to automigrate database: ERROR: column "obligation_classification_id" of relation "obligations" contains null values (SQLSTATE 23502)

Process finished with the exit code 1

[GMishx]

While trying to pass wrong data, the unmarshling failed which printed some text making the overall response invalid json.

can't parse JSON.  Raw result:

{"status":500,"message":"Failed to update license","error":"obligation classification must be one of the following values: GREEN WHITE YELLOW RED","path":"/api/v1/obligations/provide license upstream","timestamp":"2024-10-22T10:56:59+05:30"}{"status":200,"data":[{"topic":null,"type":"RISK","text":null,"classification":"WHITTTE","modifications":null,"comment":null,"active":null,"text_updatable":null,"shortnames":[]}],"paginationmeta":{"resource_count":1}}

[GMishx]

Tested, working as expected.