Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix components config #100

Merged
merged 1 commit into from
May 3, 2019
Merged

fix components config #100

merged 1 commit into from
May 3, 2019

Conversation

SampsonCrowley
Copy link
Contributor

fixes config to actually allow setting components tags as mentioned in README.md

fixes config error portion of issue #95

@SampsonCrowley SampsonCrowley force-pushed the master-components-config branch 6 times, most recently from e508a22 to 4c84a1c Compare May 3, 2019 02:12
marcandre
marcandre approved these changes May 3, 2019
View reviewed changes
Copy link
Collaborator

@marcandre marcandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great PR.
I believe it is mergeable as is, but I've included some fine-tuning comments that you may want to consider or ignore, your choice.

lib/inky/configuration.rb Outdated Show resolved Hide resolved
lib/inky/configuration.rb Outdated Show resolved Hide resolved
spec/configuration_spec.rb Show resolved Hide resolved
spec/configuration_spec.rb Show resolved Hide resolved
spec/configuration_spec.rb Show resolved Hide resolved
spec/configuration_spec.rb Show resolved Hide resolved
spec/configuration_spec.rb Show resolved Hide resolved
@SampsonCrowley SampsonCrowley force-pushed the master-components-config branch from 4c84a1c to a4fd11a Compare May 3, 2019 17:23
@SampsonCrowley
Copy link
Contributor Author

SampsonCrowley commented May 3, 2019 •
edited
Loading

@marcandre made a few tweaks based on your feedback, but left most of the possibly redundant testing in.

I'm of the opinion that it's better to "over-test" than to under do it. These scenarios were just the best way i could think of to triple check that I was testing exactly what I was expecting. I am more than willing to modify as needed though

@SampsonCrowley SampsonCrowley force-pushed the master-components-config branch from a4fd11a to f72d266 Compare May 3, 2019 18:09
@SampsonCrowley SampsonCrowley force-pushed the master-components-config branch from f72d266 to a1e8efc Compare May 3, 2019 18:11
@marcandre marcandre merged commit 2f4e079 into foundation:master May 3, 2019
@marcandre
Copy link
Collaborator

Excellent work 🙇

@marcandre
Copy link
Collaborator

BTW, the convention in Ruby is to use only implicit conversion (to_hash, to_int, ...); there are very few exceptions to this in the core language (e.g. puts/p).

@SampsonCrowley
Copy link
Contributor Author

Excellent point. Thanks for all the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcandre marcandre marcandre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SampsonCrowley @marcandre