Time Tracking Task #3
Conversation
Signed-off-by: Mo'ath Zaghdad <[email protected]>
docker-compose.yml
Outdated
| version: '3.7' | ||
|
|
||
| services: | ||
| app: |
There was a problem hiding this comment.
app is very generic, it's better to specific about which app is this
There was a problem hiding this comment.
What naming conditions would you suggest?
I'm naming it app after its role, so if I used a Postgres image its name would be db.
There was a problem hiding this comment.
I renamed it to time_tracking
I usually name the container as I explained earlier because as you know, docker-compose abbreviate the names of the containers with the folder name, so on my computer, the container name is time-tracking_app.
|
@Moath-Zaghdad Cloud you please update the code per PR comments and push the changes on this |
|
@MotasemAghbar sure, I'll do that, I'm refactoring the |
* Added flake8 and applied its code style updates Signed-off-by: Mo'ath Zaghdad <[email protected]> * fixed permissions issues and added validations to the dates (#2) * Fixed the IsStaffMemberOrReadOnly class issues. * Added validation to the start_date and end_date fields so that the end date can not occur before the start date. * Added created_by to the Event model. Signed-off-by: Mo'ath Zaghdad <[email protected]> * Added Event related constrains and more validation on the vacation date (#4) Signed-off-by: Mo'ath Zaghdad <[email protected]> * refactored the work_time model and fix the issues with the statistecs (#5) Signed-off-by: Mo'ath Zaghdad <[email protected]> * fix typos Signed-off-by: Mo'ath Zaghdad <[email protected]> * Switched to Class-based views Signed-off-by: Mo'ath Zaghdad <[email protected]>
* Docker related fixes * Use the same port as internal and external for the container * Container renamed to `time_tracking` * Used -p flag with `mkdir` to prevent errors if file exists * Replaced requirements.txt with Pipfile * Added create_at and updated_at fields Signed-off-by: Mo'ath Zaghdad <[email protected]>
Signed-off-by: Mo'ath Zaghdad <[email protected]>
Signed-off-by: = <[email protected]>
Signed-off-by: = <[email protected]>
Signed-off-by: Mo'ath Zaghdad <[email protected]>
… empty string Signed-off-by: Mo'ath Zaghdad <[email protected]>
Signed-off-by: Mo'ath Zaghdad <[email protected]>
Signed-off-by: Mo'ath Zaghdad <[email protected]>
Moath-Zaghdad
requested review from
Moath-Zaghdad
and removed request for
Moath-Zaghdad
Signed-off-by: Mo'ath Zaghdad <[email protected]>
Signed-off-by: Mo'ath Zaghdad <[email protected]>
Signed-off-by: Mo'ath Zaghdad [email protected]