Enable oci image format #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doanac
reviewed
Sep 19, 2024
Sure. I don't think we should enable OCI image format for all factories by default at once. At first, let's update dind-ci image gradually (dev, some factories, all factories). |
mike-sul
force-pushed
the
enable-oci-image-format
branch
3 times, most recently
from
08ac1c6 to
1b4884a
Compare
|
We're missing commit descriptions which explain why we're making these changes. |
Since a version of the docker running inside of the CI container supports both docker and OCI image formats it does not make sense to enforce image format conversion during pulling images from registries. Note: The older version of aklite will convert images to the docker format anyway, so no regression here. Signed-off-by: Mike Sul <[email protected]>
Add ability to enable building images in the OCI format for a factory. By default, the docker format is applied as it is now. To enable the OCI format the `ENABLE_OCI_IMAGES` should be set to "1". The Docker format is gradually becoming obsolete, with most advancements now focused on the OCI image format. This change enables us to perform end-to-end testing of OCI image format support. After that, we can offer our customers the option to transition to the new format and take advantage of its enhanced capabilities, such as switching to zstd compression. Signed-off-by: Mike Sul <[email protected]>
mike-sul
force-pushed
the
enable-oci-image-format
branch
from
1b4884a to
f616150
Compare
Updated the commit messages. |
Thanks @mike-sul |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.