helper: repo_sync: improve timeout diagnostics #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
quaresmajose
commented
Oct 3, 2024
•
quaresmajose
commented
- exit after finishing all timeout attempts
- add sleep proportional to the number of attempts before the next sync
- run repo with verbose after some failure
doanac
approved these changes
Oct 3, 2024
vanmaegima
approved these changes
Oct 3, 2024
quaresmajose
force-pushed
the
repo_sync
branch
2 times, most recently
from
8eeb414 to
2d814cb
Compare
quaresmajose
changed the title
quaresmajose
force-pushed
the
repo_sync
branch
from
2d814cb to
176a54f
Compare
| for i in $(seq 4); do | ||
| run repo init --repo-rev=v2.35 --no-clone-bundle -u $* ${REPO_INIT_OVERRIDES} && break | ||
| run repo init $_repo_extra_args --repo-rev=v2.35 --no-clone-bundle -u $* ${REPO_INIT_OVERRIDES} && break | ||
| _repo_extra_args = "--verbose" |
There was a problem hiding this comment.
What is the downside of always running with verbose?
There was a problem hiding this comment.
basically it just generates less noise, as the first time it almost always works
- exit after finishing all timeout attempts - add sleep proportional to the number of attempts before the next sync - run repo with verbose after some failure Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
force-pushed
the
repo_sync
branch
from
176a54f to
b249967
Compare
doanac
reviewed
Oct 9, 2024
| for i in $(seq 4); do | ||
| run timeout 4m repo sync && break | ||
| run timeout 4m repo sync $_repo_extra_args && break | ||
| _repo_extra_args = "--verbose" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.